Skip to content

Commit f31a697

Browse files
committed
test(llama-index): move seed creation into try block for reliable cleanup
Ensures the finally DELETE runs even if seeded_internal_id extraction fails after a successful CREATE. Addresses CodeRabbit nitpick on test robustness.
1 parent 778e8c3 commit f31a697

1 file changed

Lines changed: 11 additions & 9 deletions

File tree

tests/integration/adapters/test_llama_index.py

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -163,16 +163,18 @@ def test_vector_query_returns_results(store, tag):
163163
that label to be found by the underlying vector_search() call.
164164
"""
165165
vec = [float(i) / 16 for i in range(16)]
166-
# Seed a Chunk node with an embedding directly via Cypher.
167-
# vector_query() defaults label to "Chunk" when no MetadataFilters are provided.
168-
# Capture the internal CoordiNode node ID (returned as integer by RETURN n) so we
169-
# can assert the specific seeded node is retrieved — not just any pre-existing Chunk.
170-
seed_rows = store._client.cypher(
171-
"CREATE (n:Chunk {id: $id, text: $text, embedding: $vec}) RETURN n AS nid",
172-
params={"id": f"vec-{tag}", "text": "test chunk", "vec": vec},
173-
)
174-
seeded_internal_id = str(seed_rows[0]["nid"])
166+
# Seeding is inside the try block so that the finally cleanup always runs even if
167+
# the CREATE succeeds but extracting seeded_internal_id raises (e.g., unexpected
168+
# response format). vector_query() defaults label to "Chunk" when no
169+
# MetadataFilters are provided.
175170
try:
171+
# Capture the internal CoordiNode node ID (returned as integer by RETURN n) so
172+
# we can assert the specific seeded node is retrieved — not just any Chunk.
173+
seed_rows = store._client.cypher(
174+
"CREATE (n:Chunk {id: $id, text: $text, embedding: $vec}) RETURN n AS nid",
175+
params={"id": f"vec-{tag}", "text": "test chunk", "vec": vec},
176+
)
177+
seeded_internal_id = str(seed_rows[0]["nid"])
176178
query = VectorStoreQuery(query_embedding=vec, similarity_top_k=1)
177179
nodes, scores = store.vector_query(query)
178180

0 commit comments

Comments
 (0)