Skip to content

Commit f5d0b2c

Browse files
committed
fix(ci): install workspace packages as editable + fix lint
- ci.yml: use 'uv sync --all-packages' in test jobs so workspace members (coordinode, langchain-coordinode, llama-index-graph-stores-coordinode) are installed as proper editable packages via .pth files. Without this, uv sync only installs dev dependencies and leaves workspace packages uninstalled, causing ModuleNotFoundError in tests. - ruff.toml: update proto stubs exclude path to coordinode/coordinode/_proto/ (moved in #10); exclude _version.py (generated by hatch-vcs, unformatted) - tests/unit/test_types.py: fix I001 — remove blank line between same-group imports (pytest + coordinode._types are both third-party) - Makefile: clean target also removes coordinode/coordinode/_proto/google (google.api stubs generated alongside coordinode stubs) - Remove coordinode/_proto/__init__.py that was mistakenly committed to git (generated file, should only exist in gitignored coordinode/_proto/)
1 parent 2a63dd0 commit f5d0b2c

5 files changed

Lines changed: 6 additions & 7 deletions

File tree

.github/workflows/ci.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737
python-version: ${{ matrix.python-version }}
3838

3939
- name: Install dependencies
40-
run: uv sync
40+
run: uv sync --all-packages
4141

4242
- name: Generate proto stubs
4343
run: uv run make proto
@@ -80,7 +80,7 @@ jobs:
8080
8181
- name: Install + generate proto
8282
run: |
83-
uv sync
83+
uv sync --all-packages
8484
uv run make proto
8585
8686
- name: Integration tests

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ lint:
5454
ruff format --check coordinode/ langchain-coordinode/ llama-index-coordinode/ tests/
5555

5656
clean:
57-
rm -rf $(PROTO_OUT)/coordinode
57+
rm -rf $(PROTO_OUT)/coordinode $(PROTO_OUT)/google
5858
find . -type d -name __pycache__ -exec rm -rf {} + 2>/dev/null || true
5959
find . -type d -name "*.egg-info" -exec rm -rf {} + 2>/dev/null || true
6060
find . -type d -name dist -exec rm -rf {} + 2>/dev/null || true

coordinode/_proto/__init__.py

Lines changed: 0 additions & 2 deletions
This file was deleted.

ruff.toml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,9 @@ target-version = "py311"
33

44
exclude = [
55
# Generated proto stubs — do not lint
6-
"coordinode/_proto/",
6+
"coordinode/coordinode/_proto/",
7+
# Generated version files — do not lint
8+
"_version.py",
79
]
810

911
[lint]

tests/unit/test_types.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
"""
77

88
import pytest
9-
109
from coordinode._types import from_property_value, to_property_value
1110

1211
# Detect whether proto stubs have been generated.

0 commit comments

Comments
 (0)