Skip to content

Commit f97a0fe

Browse files
committed
test(integration): narrow xfail to AssertionError for inbound traverse
raises=AssertionError limits the xfail coverage to the known failure mode (server returns empty result → assertion fails). Unexpected errors such as gRPC RpcError or wrong enum mapping propagate as CI failures instead of being silently swallowed by the broad xfail marker. Addresses review thread #27.
1 parent b8a626f commit f97a0fe

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

tests/integration/test_sdk.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -296,9 +296,13 @@ def test_traverse_returns_neighbours(client):
296296

297297
@pytest.mark.xfail(
298298
strict=False,
299+
raises=AssertionError,
299300
# strict=False: XPASS is good news (server gained inbound support), not an error.
300301
# strict=True would break CI exactly when the server improves, which is undesirable.
301302
# The XPASS report in pytest output is the signal to remove this marker.
303+
# raises=AssertionError: narrows xfail to the known failure mode (empty result set →
304+
# assertion fails). Unexpected errors (gRPC RpcError, wrong enum, etc.) are NOT covered
305+
# and will still propagate as CI failures.
302306
reason="CoordiNode Traverse RPC does not yet support inbound direction — server returns empty result set",
303307
)
304308
def test_traverse_inbound_direction(client):

0 commit comments

Comments
 (0)