fix(storage): remove client-side signed URL render endpoint normalization (#2249)

Author: mandarini

packages/core/storage-js/src/packages/StorageFileApi.ts

@@ -667,18 +667,10 @@ export default class StorageFileApi extends BaseApiClient<StorageError> {
       if (options?.cacheNonce != null) query.set('cacheNonce', String(options.cacheNonce))
       const queryString = query.toString()
 
-      // When transforms are requested the signed URL must use the render endpoint.
-      // Some storage-api versions return /object/sign/ even for transform requests,
-      // so we normalise the path on the client side.
-      const returnedPath =
-        hasTransform && data.signedURL.includes('/object/sign/')
-          ? data.signedURL.replace('/object/sign/', '/render/image/sign/')
-          : data.signedURL
-
-      // `returnedPath` contains a `token` query parameter, so append extra params with `&` only
-      // when we actually have something to add.
+      // `data.signedURL` contains a `token` query parameter, so append extra params with `&`
+      // only when we actually have something to add.
       const signedUrl = encodeURI(
-        `${this.url}${returnedPath}${queryString ? `&${queryString}` : ''}`
+        `${this.url}${data.signedURL}${queryString ? `&${queryString}` : ''}`
       )
 
       return { signedUrl }

packages/core/storage-js/test/storageFileApi.test.ts

@@ -119,18 +119,18 @@ describe('Object API', () => {
       })
 
       expect(res.error).toBeNull()
-      expect(res.data?.signedUrl).toContain(`${URL}/render/image/sign/${bucketName}/${uploadPath}`)
+      expect(res.data?.signedUrl).toContain(`/${bucketName}/${uploadPath}`)
+      expect(res.data?.signedUrl).toContain('token=')
     })
 
-    test('sign url with empty transform object does not use render endpoint', async () => {
+    test('sign url with empty transform object uses object endpoint', async () => {
       await storage.from(bucketName).upload(uploadPath, file)
       const res = await storage.from(bucketName).createSignedUrl(uploadPath, 2000, {
         transform: {},
       })
 
       expect(res.error).toBeNull()
       expect(res.data?.signedUrl).toContain(`${URL}/object/sign/${bucketName}/${uploadPath}`)
-      expect(res.data?.signedUrl).not.toContain('/render/image/sign/')
     })
 
     test('sign url with custom filename for download', async () => {