Skip to content

Commit a664fba

Browse files
authored
Merge pull request #4 from target/pull-request-template
typo-fixes-pull-request-template
2 parents 3dffbc1 + 500c4e3 commit a664fba

4 files changed

Lines changed: 24 additions & 4 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
### ❤ THANKS FOR YOUR PULL REQUEST
2+
3+
## Proposed change
4+
5+
Describe your change and communicate why we should accept the pull request. Links to issues are helpful too, if applicable.
6+
7+
## Types of changes
8+
9+
What types of changes is this pull request introducing to this plugin? _Put an `x` in the boxes that apply_
10+
11+
- [ ] Bugfix (non-breaking change which fixes an issue)
12+
- [ ] New feature (non-breaking change which adds functionality)
13+
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
14+
15+
## Checklist
16+
17+
You can fill this out after creating your PR. _Put an `x` in the boxes that apply_
18+
19+
- [ ] I have added tests that prove my fix is effective or that my feature works
20+
- [ ] I have added necessary documentation (if appropriate)

.github/workflows/test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,5 @@ jobs:
2222
- name: check-format-on-pr
2323
run: make format
2424

25-
- name: check-link-on-pr
25+
- name: check-lint-on-pr
2626
run: make lint

internal/plugin/coverage/cobertura/report_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ import (
1212
func Test_silentlyCall(t *testing.T) {
1313
assert.Panics(t, func() {
1414
silentlyCall(func() error {
15-
return errors.New("anuthing")
15+
return errors.New("anything")
1616
})
1717
})
1818
}

scripts/start.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,8 @@ module="${PARAMETER_MODULE:-}"
2222
PARAMETER_RUN_DIR="${PARAMETER_RUN_DIR:-}"
2323
branch="${VELA_PULL_REQUEST_TARGET:-}"
2424

25-
git config --global user.name "drone"
26-
git config --global user.email "drone@drone.shipt.com"
25+
git config --global user.name "vela"
26+
git config --global user.email "vela@xyz.com"
2727

2828

2929
git fetch --no-tags origin "$branch"

0 commit comments

Comments
 (0)