refactor module name as per oss standards (#29)

Vishal Vaibhav · GitHub Enterprise · commit e433fd5e5d83 · 2021-12-06T10:07:51.000+05:30
* refactor module name as per oss standards

* make lint

* removed unneccesary folder
diff --git a/.gitignore b/.gitignore
@@ -5,3 +5,4 @@ coverage.xml
 vendor/
 /plugin
 pull-request-code-coverage
+bin
diff --git a/.vela.yml b/.vela.yml
@@ -49,10 +49,10 @@ steps:
         - pull_request
 
   - name : check-lint-on-pr
-    image: golangci/golangci-lint
+    image: hub.docker.target.com/golang:1.17
     pull: true
     commands:
-      - golangci-lint run
+      - make lint
     ruleset:
       event:
         - pull_request
diff --git a/Makefile b/Makefile
@@ -3,6 +3,7 @@ GO_PKGS=$(shell go list ./... | grep -v -e "/resources")
 
 format: check-gofmt
 
+
 check-gofmt:
 	@echo "Checking formatting..."
 	@FMT="0"; \
@@ -18,4 +19,12 @@ check-gofmt:
 		exit 1; \
 	else \
 		echo "Success - way to run gofmt!"; \
-	fi
+	fi
+
+bin/golangci-lint:
+	mkdir -p bin
+	wget -O- -nv https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s v1.24.0
+
+.PHONY: lint
+lint: bin/golangci-lint
+	bin/golangci-lint run ./...
diff --git a/bin/lint.sh b/bin/lint.sh
diff --git a/go.mod b/go.mod
@@ -1,4 +1,4 @@
-module git.target.com/searchoss/pull-request-code-coverage
+module git.target.com/target/pull-request-code-coverage
 
 go 1.17
 
diff --git a/internal/plugin/calculator/calculator.go b/internal/plugin/calculator/calculator.go
@@ -1,8 +1,8 @@
 package calculator
 
 import (
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/coverage"
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/coverage"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/domain"
 	"github.com/sirupsen/logrus"
 )
 
diff --git a/internal/plugin/coverage/cobertura/report.go b/internal/plugin/coverage/cobertura/report.go
@@ -9,8 +9,8 @@ import (
 	"os"
 	"strings"
 
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/coverage"
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/coverage"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/domain"
 	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
 )
diff --git a/internal/plugin/coverage/jacoco/report.go b/internal/plugin/coverage/jacoco/report.go
@@ -9,8 +9,8 @@ import (
 	"log"
 	"os"
 
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/coverage"
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/coverage"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/domain"
 	"github.com/pkg/errors"
 )
 
diff --git a/internal/plugin/coverage/report.go b/internal/plugin/coverage/report.go
@@ -1,6 +1,6 @@
 package coverage
 
-import "git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"
+import "git.target.com/target/pull-request-code-coverage/internal/plugin/domain"
 
 type Loader interface {
 	Load(coverageFile string) (Report, error)
diff --git a/internal/plugin/reporter/forking.go b/internal/plugin/reporter/forking.go
@@ -1,7 +1,7 @@
 package reporter
 
 import (
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/domain"
 	"github.com/pkg/errors"
 )
 
diff --git a/internal/plugin/reporter/forking_test.go b/internal/plugin/reporter/forking_test.go
@@ -3,7 +3,7 @@ package reporter
 import (
 	"testing"
 
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/domain"
 	"github.com/pkg/errors"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/mock"
diff --git a/internal/plugin/reporter/github_pr.go b/internal/plugin/reporter/github_pr.go
@@ -6,9 +6,9 @@ import (
 	"io"
 	"strings"
 
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/pluginhttp"
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/pluginjson"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/domain"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/pluginhttp"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/pluginjson"
 	"github.com/pkg/errors"
 )
 
diff --git a/internal/plugin/reporter/github_pr_test.go b/internal/plugin/reporter/github_pr_test.go
@@ -5,9 +5,9 @@ import (
 	"net/http/httptest"
 	"testing"
 
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/pluginhttp"
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/pluginjson"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/domain"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/pluginhttp"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/pluginjson"
 	"github.com/pkg/errors"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/mock"
diff --git a/internal/plugin/reporter/mocks.go b/internal/plugin/reporter/mocks.go
@@ -1,7 +1,7 @@
 package reporter
 
 import (
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/domain"
 	"github.com/stretchr/testify/mock"
 )
 
diff --git a/internal/plugin/reporter/reporter.go b/internal/plugin/reporter/reporter.go
@@ -1,7 +1,7 @@
 package reporter
 
 import (
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/domain"
 )
 
 type Reporter interface {
diff --git a/internal/plugin/reporter/simple.go b/internal/plugin/reporter/simple.go
@@ -6,7 +6,7 @@ import (
 	"io"
 	"log"
 
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/domain"
 )
 
 type Simple struct {
diff --git a/internal/plugin/reporter/utils.go b/internal/plugin/reporter/utils.go
@@ -4,7 +4,7 @@ import (
 	"fmt"
 	"strings"
 
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/domain"
 )
 
 func lineDescription(l domain.SourceLine) string {
diff --git a/internal/plugin/runner.go b/internal/plugin/runner.go
@@ -6,14 +6,14 @@ import (
 	"strconv"
 	"strings"
 
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/calculator"
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/coverage"
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/coverage/cobertura"
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/coverage/jacoco"
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/pluginhttp"
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/pluginjson"
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/reporter"
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/sourcelines/unifieddiff"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/calculator"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/coverage"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/coverage/cobertura"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/coverage/jacoco"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/pluginhttp"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/pluginjson"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/reporter"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/sourcelines/unifieddiff"
 	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
 )
diff --git a/internal/plugin/runner_test.go b/internal/plugin/runner_test.go
@@ -7,7 +7,7 @@ import (
 	"strconv"
 	"testing"
 
-	"git.target.com/searchoss/pull-request-code-coverage/internal/test/mocks"
+	"git.target.com/target/pull-request-code-coverage/internal/test/mocks"
 	"github.com/stretchr/testify/assert"
 )
 
@@ -75,7 +75,7 @@ func TestDefaultRunner_Run_GoExample_WithSourceDir(t *testing.T) {
 		propGetter.On("GetProperty", "PARAMETER_COVERAGE_FILE").Return("../test/example_go_coverage_with_source_dir.xml", true)
 		propGetter.On("GetProperty", "PARAMETER_COVERAGE_TYPE").Return("cobertura", true)
 		propGetter.On("GetProperty", "PARAMETER_MODULE").Return("", false)
-		propGetter.On("GetProperty", "PARAMETER_SOURCE_DIRS").Return("/go/git.target.com/searchoss/pull-request-code-coverage", true)
+		propGetter.On("GetProperty", "PARAMETER_SOURCE_DIRS").Return("/go/git.target.com/target/pull-request-code-coverage", true)
 		propGetter.On("GetProperty", "PARAMETER_GH_API_KEY").Return("SOME_API_KEY", true)
 		propGetter.On("GetProperty", "PARAMETER_GH_API_BASE_URL").Return(mockServerURL, true)
 		propGetter.On("GetProperty", "PARAMETER_MODULE").Return("", false)
@@ -146,7 +146,7 @@ func TestDefaultRunner_Run_GoExample(t *testing.T) {
 		propGetter.On("GetProperty", "PARAMETER_COVERAGE_FILE").Return("../test/example_go_coverage.xml", true)
 		propGetter.On("GetProperty", "PARAMETER_COVERAGE_TYPE").Return("cobertura", true)
 		propGetter.On("GetProperty", "PARAMETER_MODULE").Return("", false)
-		propGetter.On("GetProperty", "PARAMETER_SOURCE_DIRS").Return("/go/git.target.com/searchoss/pull-request-code-coverage", true)
+		propGetter.On("GetProperty", "PARAMETER_SOURCE_DIRS").Return("/go/git.target.com/target/pull-request-code-coverage", true)
 		propGetter.On("GetProperty", "PARAMETER_GH_API_KEY").Return("SOME_API_KEY", true)
 		propGetter.On("GetProperty", "PARAMETER_GH_API_BASE_URL").Return(mockServerURL, true)
 		propGetter.On("GetProperty", "PARAMETER_MODULE").Return("", false)
diff --git a/internal/plugin/sourcelines/loader.go b/internal/plugin/sourcelines/loader.go
@@ -3,7 +3,7 @@ package sourcelines
 import (
 	"os"
 
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/domain"
 )
 
 type Loader interface {
diff --git a/internal/plugin/sourcelines/unifieddiff/changed_source_loader.go b/internal/plugin/sourcelines/unifieddiff/changed_source_loader.go
@@ -8,7 +8,7 @@ import (
 	"strconv"
 	"strings"
 
-	"git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"
+	"git.target.com/target/pull-request-code-coverage/internal/plugin/domain"
 	"github.com/pkg/errors"
 )
 
diff --git a/internal/test/example_go_coverage.xml b/internal/test/example_go_coverage.xml
diff --git a/internal/test/example_go_coverage_with_source_dir.xml b/internal/test/example_go_coverage_with_source_dir.xml
diff --git a/internal/test/example_go_unified.diff b/internal/test/example_go_unified.diff
diff --git a/main.go b/main.go

-Original file line number
+Diff line change
 vendor/
 /plugin
 pull-request-code-coverage
 +bin
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-module git.target.com/searchoss/pull-request-code-coverage`
	`1`	`+module git.target.com/target/pull-request-code-coverage`
`2`	`2`
`3`	`3`	`go 1.17`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`	`1`	`package calculator`
`2`	`2`
`3`	`3`	`import (`
`4`		`- "git.target.com/searchoss/pull-request-code-coverage/internal/plugin/coverage"`
`5`		`- "git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"`
	`4`	`+ "git.target.com/target/pull-request-code-coverage/internal/plugin/coverage"`
	`5`	`+ "git.target.com/target/pull-request-code-coverage/internal/plugin/domain"`
`6`	`6`	`"github.com/sirupsen/logrus"`
`7`	`7`	`)`
`8`	`8`
Original file line number	Diff line number	Diff line change
`@@ -9,8 +9,8 @@ import (`
`9`	`9`	`"log"`
`10`	`10`	`"os"`
`11`	`11`
`12`		`- "git.target.com/searchoss/pull-request-code-coverage/internal/plugin/coverage"`
`13`		`- "git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"`
	`12`	`+ "git.target.com/target/pull-request-code-coverage/internal/plugin/coverage"`
	`13`	`+ "git.target.com/target/pull-request-code-coverage/internal/plugin/domain"`
`14`	`14`	`"github.com/pkg/errors"`
`15`	`15`	`)`
`16`	`16`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,7 @@`
`1`	`1`	`package reporter`
`2`	`2`
`3`	`3`	`import (`
`4`		`- "git.target.com/searchoss/pull-request-code-coverage/internal/plugin/domain"`
	`4`	`+ "git.target.com/target/pull-request-code-coverage/internal/plugin/domain"`
`5`	`5`	`"github.com/pkg/errors"`
`6`	`6`	`)`
`7`	`7`