Commit 5c65170
authored
Remove support for docker-in-docker, privileged and loopback-audio docker-worker features (#753)
As far as I know they're unused at this point. In addition:
- docker-in-docker involves talking to the docker daemon on the host,
which has proven problematic as it bakes in dependencies on the docker
daemon's version. It's also dubious from a security perspective, and
as far as I can tell doesn't work in generic-worker/d2g (it doesn't
have a proxy to only allow "safe" commands)
- privileged is inherently problematic as it makes the task
root-equivalent on the worker
- loopback audio these days is achieved with dummy devices at the
pulseaudio or pipewire level, not at the kernel level1 parent eb71f22 commit 5c65170
1 file changed
Lines changed: 4 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
273 | 273 | | |
274 | 274 | | |
275 | 275 | | |
276 | | - | |
277 | | - | |
278 | | - | |
279 | 276 | | |
280 | 277 | | |
281 | 278 | | |
| |||
356 | 353 | | |
357 | 354 | | |
358 | 355 | | |
359 | | - | |
360 | | - | |
361 | | - | |
362 | 356 | | |
363 | 357 | | |
364 | 358 | | |
| |||
375 | 369 | | |
376 | 370 | | |
377 | 371 | | |
378 | | - | |
379 | | - | |
380 | | - | |
381 | | - | |
382 | | - | |
383 | | - | |
384 | | - | |
385 | | - | |
386 | | - | |
387 | | - | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
388 | 376 | | |
389 | 377 | | |
390 | 378 | | |
| |||
815 | 803 | | |
816 | 804 | | |
817 | 805 | | |
818 | | - | |
819 | | - | |
820 | | - | |
821 | 806 | | |
822 | 807 | | |
823 | 808 | | |
| |||
0 commit comments