PHP 8.4 deprecation warning/issues

[Eikzx]

Hello,

I updated a project of our to PHP 8.4 today and while importing I got loads of deprecation warning issues with techdivision.
Especially with "vendor/techdivision/import/src/Adapter/Goodby/Exporter.php" it seems the escape parameter is not provided to the fputcsv function.

Are there any plans regarding compatibility with PHP >= 8.4?

Kindest regards
Eike

[immhusnainali]

Hey ,
This looks like a genuine PHP 8.4 compatibility issue.

As of PHP 8.4, calls to fputcsv() should provide the $escape parameter explicitly. The implementation in src/Adapter/Goodby/Exporter.php appears to omit that argument and therefore triggers the deprecation warning.

A compatible adjustment would be to change the call to:
fputcsv($handle, $row, $delimiter, $enclosure, '');

Regards
Husnain

[Eikzx]

Hi,

yes I located the issues there as well and have fixed it with a Patch (see attached).
Anyone who has this issue might be able to fix it with this patch as well.
The config even provides a method to get the "Escape param" thus I just get it from the config so it stays configurable depending on the need.

Exporter.patch

Regards
Eike