Merge pull request #24 from mfateev/signal

Added stub creation by id to HelloSignal

Author: mfateev

src/main/java/com/uber/cadence/samples/bookingsaga/TripBookingSaga.java

@@ -27,8 +27,8 @@ public class TripBookingSaga {
 
   static final String TASK_LIST = "TripBooking";
 
+  @SuppressWarnings("CatchAndPrintStackTrace")
   public static void main(String[] args) {
-
     // Get worker to poll the common task list.
     Worker.Factory factory = new Worker.Factory(DOMAIN);
     final Worker workerForCommonTaskList = factory.newWorker(TASK_LIST);

src/main/java/com/uber/cadence/samples/hello/HelloSignal.java

@@ -28,6 +28,7 @@
 import java.time.Duration;
 import java.util.ArrayList;
 import java.util.List;
+import org.apache.commons.lang.RandomStringUtils;
 
 /**
  * Demonstrates asynchronous signalling of a workflow. Requires a local instance of Cadence server
@@ -51,7 +52,6 @@ public interface GreetingWorkflow {
     @SignalMethod
     void waitForName(String name);
 
-    /** Receives name through an external signal. */
     @SignalMethod
     void exit();
   }
@@ -94,29 +94,39 @@ public static void main(String[] args) throws Exception {
     worker.registerWorkflowImplementationTypes(GreetingWorkflowImpl.class);
     factory.start();
 
+    // In a real application use a business ID like customer ID or order ID
+    String workflowId = RandomStringUtils.randomAlphabetic(10);
+
     // Start a workflow execution. Usually this is done from another program.
     WorkflowClient workflowClient = WorkflowClient.newInstance(DOMAIN);
     // Get a workflow stub using the same task list the worker uses.
+    // The newly started workflow is going to have the workflowId generated above.
     WorkflowOptions workflowOptions =
         new WorkflowOptions.Builder()
             .setTaskList(TASK_LIST)
             .setExecutionStartToCloseTimeout(Duration.ofSeconds(30))
+            .setWorkflowId(workflowId)
             .build();
     GreetingWorkflow workflow =
         workflowClient.newWorkflowStub(GreetingWorkflow.class, workflowOptions);
     // Start workflow asynchronously to not use another thread to signal.
     WorkflowClient.start(workflow::getGreetings);
     // After start for getGreeting returns, the workflow is guaranteed to be started.
-    // So we can send a signal to it using workflow stub.
+    // So we can send a signal to it using the workflow stub.
     // This workflow keeps receiving signals until exit is called
-    workflow.waitForName("World");
-    workflow.waitForName("Universe");
-    workflow.exit();
+    workflow.waitForName("World"); // sends waitForName signal
+
+    // Create a new stub using the workflowId.
+    // This is to demonstrate that to send a signal only the workflowId is required.
+    GreetingWorkflow workflowById =
+        workflowClient.newWorkflowStub(GreetingWorkflow.class, workflowId);
+    workflowById.waitForName("Universe"); // sends waitForName signal
+    workflowById.exit(); // sends exit signal
     // Calling synchronous getGreeting after workflow has started reconnects to the existing
     // workflow and blocks until a result is available. Note that this behavior assumes that
     // WorkflowOptions are not configured with WorkflowIdReusePolicy.AllowDuplicate. In that case
     // the call would fail with WorkflowExecutionAlreadyStartedException.
-    List<String> greetings = workflow.getGreetings();
+    List<String> greetings = workflowById.getGreetings();
     System.out.println(greetings);
     System.exit(0);
   }