Revert tool call iteration limit, match Spring AI's recursive pattern

Remove MAX_TOOL_CALL_ITERATIONS and the iterative loop. Use recursive
internalCall() matching Spring AI's OpenAiChatModel pattern. Temporal's
activity timeouts and workflow execution timeout already bound runaway
tool loops.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: donald-pinckney

TASK_QUEUE.json

@@ -79,8 +79,8 @@
       "depends_on": [
         "T1"
       ],
-      "status": "completed",
-      "notes": "Do after type conversion tests exist to verify we don't break the call flow."
+      "status": "reverted",
+      "notes": "Reverted: Spring AI does not limit tool call iterations either. Temporal activity timeouts and workflow execution timeout provide the safety net."
     },
     {
       "id": "T8",

temporal-spring-ai/src/main/java/io/temporal/springai/model/ActivityChatModel.java

@@ -83,9 +83,6 @@ public class ActivityChatModel implements ChatModel {
   /** Default maximum retry attempts for chat model activity calls. */
   public static final int DEFAULT_MAX_ATTEMPTS = 3;
 
-  /** Maximum number of tool call iterations before aborting to prevent infinite loops. */
-  public static final int MAX_TOOL_CALL_ITERATIONS = 10;
-
   private final ChatModelActivity chatModelActivity;
   private final String modelName;
   private final ToolCallingManager toolCallingManager;
@@ -190,24 +187,22 @@ public ChatOptions getDefaultOptions() {
 
   @Override
   public ChatResponse call(Prompt prompt) {
-    Prompt currentPrompt = prompt;
-
-    for (int iteration = 0; iteration < MAX_TOOL_CALL_ITERATIONS; iteration++) {
-      // Convert prompt to activity input and call the activity
-      ChatModelTypes.ChatModelActivityInput input = createActivityInput(currentPrompt);
-      ChatModelTypes.ChatModelActivityOutput output = chatModelActivity.callChatModel(input);
+    return internalCall(prompt);
+  }
 
-      // Convert activity output to ChatResponse
-      ChatResponse response = toResponse(output);
+  private ChatResponse internalCall(Prompt prompt) {
+    // Convert prompt to activity input and call the activity
+    ChatModelTypes.ChatModelActivityInput input = createActivityInput(prompt);
+    ChatModelTypes.ChatModelActivityOutput output = chatModelActivity.callChatModel(input);
 
-      // If no tool calls requested, return the response
-      if (currentPrompt.getOptions() == null
-          || !toolExecutionEligibilityPredicate.isToolExecutionRequired(
-              currentPrompt.getOptions(), response)) {
-        return response;
-      }
+    // Convert activity output to ChatResponse
+    ChatResponse response = toResponse(output);
 
-      var toolExecutionResult = toolCallingManager.executeToolCalls(currentPrompt, response);
+    // Handle tool calls if the model requested them
+    if (prompt.getOptions() != null
+        && toolExecutionEligibilityPredicate.isToolExecutionRequired(
+            prompt.getOptions(), response)) {
+      var toolExecutionResult = toolCallingManager.executeToolCalls(prompt, response);
 
       if (toolExecutionResult.returnDirect()) {
         return ChatResponse.builder()
@@ -216,15 +211,12 @@ public ChatResponse call(Prompt prompt) {
             .build();
       }
 
-      // Continue loop with tool results sent back to the model
-      currentPrompt =
-          new Prompt(toolExecutionResult.conversationHistory(), currentPrompt.getOptions());
+      // Send tool results back to the model
+      return internalCall(
+          new Prompt(toolExecutionResult.conversationHistory(), prompt.getOptions()));
     }
 
-    throw new IllegalStateException(
-        "Chat model exceeded maximum tool call iterations ("
-            + MAX_TOOL_CALL_ITERATIONS
-            + "). This may indicate the model is stuck in a tool-calling loop.");
+    return response;
   }
 
   private ChatModelTypes.ChatModelActivityInput createActivityInput(Prompt prompt) {