move database port and user defaults to toolbox; move is_localdb test to toolbox

Author: thorstenkampe

sql shell.exe

@@ -13,31 +13,23 @@
 
 dbms_defaults   = {
     'MSSQL': {
-        'port':   1433,
-        'user':   'sa',
         'shell':  'mssql-cli',
         'shell-windows': 'mssql-cli.bat',
         'legacy': 'sqlcmd'
     },
 
     'MySQL': {
-        'port':   3306,
-        'user':   'root',
         'shell':  'mycli',
         'legacy': 'mysql'
     },
 
     'Oracle': {
-        'port':   1521,
-        'user':   'sys',
         'shell':  'sql',
         'shell-windows': 'sql.exe',
         'legacy': 'sqlplus'
     },
 
     'PostgreSQL': {
-        'port':   5432,
-        'user':   'postgres',
         'shell':  'pgcli',
         'legacy': 'psql'
     },
@@ -142,8 +134,8 @@ def on_ok(self):  # NOSONAR
         except KeyError:
             dsn = ''
         host        = self.host.value or 'localhost'
-        port        = self.port.value or db_defaults.get('port')
-        user        = self.user.value or db_defaults.get('user')
+        port        = self.port.value or tb.defaults['port'].get(dbtype.lower())
+        user        = self.user.value or tb.defaults['db_user'].get(dbtype.lower())
         passwd      = self.passwd.value
         db          = self.db.value
 
@@ -229,8 +221,7 @@ def on_ok(self):  # NOSONAR
         # SPECIAL CASES FOR RDBMS
         if   dbtype == 'MSSQL':
             # named pipe connection to LocalDB
-            localdb = r'(localdb)\mssqllocaldb'
-            if localdb in dsn.lower() or host.lower() == localdb:
+            if tb.is_localdb(dsn) or tb.is_localdb(host):
                 opts.remove('-N')          # `-N` = "encrypt"  (NOSONAR)
                 conn_params[5] = '{host}'  # host,port -> host
 

sql shell.py

@@ -1,4 +1,33 @@
-import sys
+import sys, urllib
+
+defaults = {
+    'port':    {
+        'mssql':      1433,
+        'mysql':      3306,
+        'oracle':     1521,
+        'postgresql': 5432
+    },
+
+    'db_user': {
+        'mssql':      'sa',
+        'mysql':      'root',
+        'oracle':     'sys',
+        'postgresql': 'postgres'
+    }
+}
+
+def is_localdb(dsn):
+    localdb    = r'(localdb)\mssqllocaldb'
+    parsed_url = urllib.parse.urlsplit(dsn)
+
+    if   parsed_url.scheme == 'mssql':
+        return parsed_url.hostname == localdb
+
+    elif not parsed_url.scheme:
+        return localdb in parsed_url.path.lower()
+
+    else:
+        return False
 
 # https://pyinstaller.readthedocs.io/en/stable/runtime-information.html
 def is_pyinstaller():