trim the labels (#419)

* trim the labels

leading and trailing spaces are not possible in github
so trim the labels before matching them

fixes #416

* lint

* fix bug

Author: mawinter69

app/command-enabled.js

@@ -9,6 +9,10 @@ function notEnabled(command) {
   };
 }
 
+function trimLabels(labels) {
+  return labels.map((it) => it.trim());
+}
+
 export function transferEnabled(config) {
   if (!config.commands.transfer.enabled) {
     return notEnabled("transfer");
@@ -24,14 +28,15 @@ export function labelEnabled(config, labels) {
     return notEnabled("label");
   }
 
+  const allowedLabels = trimLabels(labelConfig.allowedLabels);
   if (
     // if length is = 0 then all labels are allowed
-    labelConfig.allowedLabels.length > 0 &&
-    !labels.every((label) => labelConfig.allowedLabels.includes(label))
+    allowedLabels.length > 0 &&
+    !labels.every((label) => allowedLabels.includes(label))
   ) {
     return {
       enabled: false,
-      error: `${labels} doesn't match the allowed labels \`${labelConfig.allowedLabels.join(
+      error: `${labels} doesn't match the allowed labels \`${allowedLabels.join(
         ",",
       )}\``,
     };
@@ -62,14 +67,15 @@ export function removeLabelEnabled(config, labels) {
     return notEnabled("remove-label");
   }
 
+  const allowedLabels = trimLabels(labelConfig.allowedLabels);
   if (
     // if length is = 0 then all labels are allowed
-    labelConfig.allowedLabels.length > 0 &&
-    !labels.every((label) => labelConfig.allowedLabels.includes(label))
+    allowedLabels.length > 0 &&
+    !labels.every((label) => allowedLabels.includes(label))
   ) {
     return {
       enabled: false,
-      error: `${labels} doesn't match the allowed labels \`${labelConfig.allowedLabels.join(
+      error: `${labels} doesn't match the allowed labels \`${allowedLabels.join(
         ",",
       )}\``,
     };

app/command-enabled.test.js

@@ -127,6 +127,22 @@ describe("command-enabled", () => {
     });
   });
 
+  test("is enabled when label is in allowedLabels with blanks", () => {
+    const sut = labelEnabled(
+      {
+        commands: {
+          label: {
+            enabled: true,
+            allowedLabels: ["label2", "label1 "],
+          },
+        },
+      },
+      ["label1"],
+    );
+
+    expect(sut.enabled).toEqual(true);
+  });
+
   describe("closeEnabled", () => {
     test("is enabled when config is enabled", () => {
       const sut = closeEnabled({

app/converters.js

@@ -8,5 +8,8 @@ export function extractUsersAndTeams(orgName, reviewers) {
 }
 
 export function extractCommaSeparated(item) {
-  return item.split(",").filter(Boolean);
+  return item
+    .split(",")
+    .filter(Boolean)
+    .map((it) => it.trim());
 }

app/converters.test.js

@@ -92,6 +92,11 @@ describe("converters", () => {
     test("remove empty string entries in split", () => {
       const labels = extractCommaSeparated("label1, ,label2");
 
+      expect(labels).toEqual(expect.arrayContaining(actual));
+    });
+    test("remove trailing whitespace in split", () => {
+      const labels = extractCommaSeparated("label1, label2");
+
       expect(labels).toEqual(expect.arrayContaining(actual));
     });
   });