Skip to content

Commit 994e192

Browse files
authored
fix: zizorm warnings (#1054)
Signed-off-by: Olivier Vernin <me@olblak.com>
1 parent 13d866a commit 994e192

6 files changed

Lines changed: 44 additions & 0 deletions

File tree

.github/workflows/check-dist.yml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,20 +17,29 @@ on:
1717
paths-ignore:
1818
- "**.md"
1919
workflow_dispatch:
20+
21+
permissions: {}
22+
2023
jobs:
2124
check-dist:
2225
runs-on: ubuntu-latest
2326
steps:
2427
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
28+
with:
29+
persist-credentials: false
30+
2531
- name: Set Node.js 24.x
2632
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
2733
with:
2834
node-version: 24
2935
cache: npm
36+
3037
- name: Install dependencies
3138
run: npm ci
39+
3240
- name: Rebuild the dist/ directory
3341
run: npm run prepare
42+
3443
- name: Compare the expected and actual dist/ directories
3544
run: |
3645
if [ "$(git diff --ignore-space-at-eol dist/ | wc -l)" -gt "0" ]; then
@@ -39,6 +48,7 @@ jobs:
3948
exit 1
4049
fi
4150
id: diff
51+
4252
# If index.js was different than expected, upload the expected version as an artifact
4353
- uses: actions/upload-artifact@bbbca2ddaa5d8feaa63e36b76fdaad77386f024f # v7.0.0
4454
if: ${{ failure() && steps.diff.conclusion == 'failure' }}

.github/workflows/test.yaml

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,24 +17,35 @@ jobs:
1717
runs-on: ubuntu-latest
1818
steps:
1919
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
20+
with:
21+
persist-credentials: false
22+
2023
- name: Set Node.js 24.x
2124
uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
2225
with:
2326
node-version: 24
2427
cache: npm
28+
2529
- name: Install Dependencies
2630
run: npm ci
31+
2732
- name: Run Lint Test
2833
run: npm run lint
34+
2935
- name: Run tests
3036
run: npm test
37+
3138
e2e:
3239
name: Test Updatecli Github Action
3340
runs-on: ubuntu-latest
3441
steps:
3542
- name: Git Checkout
3643
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
44+
with:
45+
persist-credentials: false
46+
3747
- name: Install Updatecli
3848
uses: ./
49+
3950
- name: Test local action without install-only
4051
run: updatecli diff --config testdata/updatecli.d/test.yaml

.github/workflows/updatecli.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,14 @@ jobs:
1414
steps:
1515
- name: "Checkout"
1616
uses: "actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd" # v6.0.2
17+
with:
18+
persist-credentials: false
19+
1720
- name: "Setup updatecli"
1821
uses: "updatecli/updatecli-action@4b17f4ea784de29f71f85f9bc4955402ba1ae53c" # v2.100.0
1922
with:
2023
version: "v0.114.0"
24+
2125
- name: "Run updatecli"
2226
run: updatecli compose apply --clean-git-branches=true --experimental
2327
env:

.github/workflows/updatecli_test.yaml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,14 @@ jobs:
1212
steps:
1313
- name: "Checkout"
1414
uses: "actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd" # v6.0.2
15+
with:
16+
persist-credentials: false
17+
1518
- name: "Setup updatecli"
1619
uses: "updatecli/updatecli-action@4b17f4ea784de29f71f85f9bc4955402ba1ae53c" # v2.100.0
1720
with:
1821
version: "v0.114.0"
22+
1923
- name: "Test updatecli in dry-run mode"
2024
run: "updatecli compose diff"
2125
env:

.github/workflows/updatecli_update.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,10 +17,14 @@ jobs:
1717
steps:
1818
- name: "Checkout"
1919
uses: "actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd" # v6.0.2
20+
with:
21+
persist-credentials: false
22+
2023
- name: "Setup updatecli"
2124
uses: "updatecli/updatecli-action@4b17f4ea784de29f71f85f9bc4955402ba1ae53c" # v2.100.0
2225
with:
2326
version: "v0.114.0"
27+
2428
- name: "Run updatecli only on monitored pipelines"
2529
run: updatecli compose apply --clean-git-branches=true --labels="monitoring:enabled" --experimental
2630
env:
@@ -30,6 +34,7 @@ jobs:
3034
UPDATECLI_UDASH_API_URL: ${{ secrets.UPDATECLI_UDASH_API_URL }}
3135
UPDATECLI_UDASH_ACCESS_TOKEN: ${{ secrets.UPDATECLI_UDASH_ACCESS_TOKEN }}
3236
UPDATECLI_UDASH_URL: ${{ secrets.UPDATECLI_UDASH_URL }}
37+
3338
- name: "Run updatecli only on existing pipelines"
3439
run: updatecli compose apply --clean-git-branches=true --existing-only=true --experimental
3540
env:

.github/zizmor.yaml

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
rules:
2+
secrets-outside-env:
3+
config:
4+
allow:
5+
- UPDATECLIBOT_APP_ID
6+
- UPDATECLIBOT_APP_PRIVKEY
7+
- UPDATECLIBOT_APP_INSTALLATION_ID
8+
- UPDATECLI_UDASH_API_URL
9+
- UPDATECLI_UDASH_ACCESS_TOKEN
10+
- UPDATECLI_UDASH_URL

0 commit comments

Comments
 (0)