fix(utils): add nil and pointer validation to ReadYAML function across multiple packages

Author: osmontero

agent/utils/files.go

@@ -8,6 +8,7 @@ import (
 	"io"
 	"os"
 	"path/filepath"
+	"reflect"
 
 	"gopkg.in/yaml.v2"
 )
@@ -22,6 +23,15 @@ func GetMyPath() string {
 }
 
 func ReadYAML(path string, result interface{}) error {
+	if result == nil {
+		return fmt.Errorf("result interface is nil")
+	}
+
+	rv := reflect.ValueOf(result)
+	if rv.Kind() != reflect.Ptr || rv.IsNil() {
+		return fmt.Errorf("result must be a non-nil pointer")
+	}
+
 	file, err := os.Open(path)
 	if err != nil {
 		return err

installer/utils/os.go

@@ -7,6 +7,7 @@ import (
 	"os"
 	"os/exec"
 	"path/filepath"
+	"reflect"
 
 	"gopkg.in/yaml.v3"
 )
@@ -51,12 +52,12 @@ func RunCmd(command string, arg ...string) error {
 
 func RunCmdWithOutput(command string, arg ...string) ([]string, error) {
 	cmd := exec.Command(command, arg...)
-	
+
 	output, err := cmd.Output()
 	if err != nil {
 		return nil, fmt.Errorf("error running command: %v", err)
 	}
-	
+
 	lines := bytes.Split(output, []byte("\n"))
 	result := make([]string, 0, len(lines))
 	for _, line := range lines {
@@ -65,7 +66,7 @@ func RunCmdWithOutput(command string, arg ...string) ([]string, error) {
 			result = append(result, string(trimmed))
 		}
 	}
-	
+
 	return result, nil
 }
 
@@ -127,6 +128,15 @@ func WriteYAML(url string, data any) error {
 }
 
 func ReadYAML(path string, result any) error {
+	if result == nil {
+		return fmt.Errorf("result interface is nil")
+	}
+
+	rv := reflect.ValueOf(result)
+	if rv.Kind() != reflect.Ptr || rv.IsNil() {
+		return fmt.Errorf("result must be a non-nil pointer")
+	}
+
 	file, err := os.Open(path)
 	if err != nil {
 		return err

plugins/config/main.go

@@ -803,11 +803,6 @@ func writeRules(rules []Rule) error {
 				return catcher.Error("failed to write to file", err, map[string]any{"process": "plugin_com.utmstack.config"})
 			}
 
-			err = file.Close()
-			if err != nil {
-				return catcher.Error("failed to close file", err, map[string]any{"process": "plugin_com.utmstack.config"})
-			}
-
 			return nil
 		}()
 
@@ -851,10 +846,5 @@ func writePatterns(patterns map[string]string) error {
 		return catcher.Error("failed to write to file", err, map[string]any{"process": "plugin_com.utmstack.config"})
 	}
 
-	err = file.Close()
-	if err != nil {
-		return catcher.Error("failed to close file", err, map[string]any{"process": "plugin_com.utmstack.config"})
-	}
-
 	return nil
 }

plugins/feeds/internal/client/dependencies.go

@@ -22,6 +22,7 @@ func NewClientDependencies(cfg *config.TWConfig) (*ClientDependencies, error) {
 
 	deps := &ClientDependencies{
 		Backend:     NewBackendClient(cfg),
+		CM:          &CustomersManagerClient{},
 		ThreadWinds: NewThreadWindsClient(cfg),
 		OpenSearch:  opensearch,
 	}

plugins/feeds/utils/files.go

@@ -2,11 +2,22 @@ package utils
 
 import (
 	"os"
+	"reflect"
 
+	"github.com/threatwinds/go-sdk/catcher"
 	"gopkg.in/yaml.v2"
 )
 
 func ReadYAML(path string, result interface{}) error {
+	if result == nil {
+		return catcher.Error("result interface is nil", nil, nil)
+	}
+
+	rv := reflect.ValueOf(result)
+	if rv.Kind() != reflect.Ptr || rv.IsNil() {
+		return catcher.Error("result must be a non-nil pointer", nil, nil)
+	}
+
 	file, err := os.Open(path)
 	if err != nil {
 		return err

utmstack-collector/utils/files.go

@@ -2,8 +2,10 @@ package utils
 
 import (
 	"encoding/json"
+	"fmt"
 	"os"
 	"path/filepath"
+	"reflect"
 
 	"gopkg.in/yaml.v2"
 )
@@ -18,6 +20,15 @@ func GetMyPath() string {
 }
 
 func ReadYAML(path string, result interface{}) error {
+	if result == nil {
+		return fmt.Errorf("result interface is nil")
+	}
+
+	rv := reflect.ValueOf(result)
+	if rv.Kind() != reflect.Ptr || rv.IsNil() {
+		return fmt.Errorf("result must be a non-nil pointer")
+	}
+
 	file, err := os.Open(path)
 	if err != nil {
 		return err