Alter locks

Author: fogelito

src/Database/Adapter.php

@@ -31,6 +31,8 @@ abstract class Adapter
 
     protected int $inTransaction = 0;
 
+    protected bool $alterLocks = false;
+
     /**
      * @var array<string, mixed>
      */
@@ -1434,4 +1436,23 @@ abstract public function setSupportForAttributes(bool $support): bool;
      */
     abstract public function getSupportForIntegerBooleans(): bool;
 
+    /**
+     * Does the adapter has support to change default lock mode?
+     *
+     * @return bool
+     */
+    abstract public function getSupportForAlterLocks(): bool;
+
+    /**
+     * @param bool $bool
+     *
+     * @return $this
+     * @throws Exception
+     */
+    public function enableLocks(bool $bool): self
+    {
+        $this->alterLocks = $bool;
+
+        return $this;
+    }
 }

src/Database/Adapter/MariaDB.php

@@ -2215,8 +2215,8 @@ public function getSupportForOptionalSpatialAttributeWithExistingRows(): bool
         return true;
     }
 
-    public function getLockType(): string
+    public function getSupportForAlterLocks(): bool
     {
-        return ',LOCK=SHARED';
+        return true;
     }
 }

src/Database/Adapter/Mongo.php

@@ -3209,4 +3209,9 @@ public function getTenantQuery(string $collection, string $alias = ''): string
     {
         return '';
     }
+
+    public function getSupportForAlterLocks(): bool
+    {
+        return false;
+    }
 }

src/Database/Adapter/Pool.php

@@ -632,4 +632,9 @@ public function setAuthorization(Authorization $authorization): self
         $this->authorization = $authorization;
         return $this;
     }
+
+    public function getSupportForAlterLocks(): bool
+    {
+        return $this->delegate(__FUNCTION__, \func_get_args());
+    }
 }

src/Database/Adapter/SQL.php

@@ -259,11 +259,6 @@ public function createAttribute(string $collection, string $id, string $type, in
         }
     }
 
-    public function getLockType(): string
-    {
-        return '';
-    }
-
     /**
      * Create Attributes
      *
@@ -3519,4 +3514,18 @@ public function setSupportForAttributes(bool $support): bool
     {
         return true;
     }
+
+    public function getSupportForAlterLocks(): bool
+    {
+        return false;
+    }
+
+    public function getLockType(): string
+    {
+        if ($this->getSupportForAlterLocks() && $this->alterLocks) {
+            return ',LOCK=SHARED';
+        }
+
+        return '';
+    }
 }

src/Database/Adapter/SQLite.php

@@ -1867,8 +1867,8 @@ public function getUpsertStatement(
         return $stmt;
     }
 
-    public function getLockType(): string
+    public function getSupportForAlterLocks(): bool
     {
-        return '';
+        return false;
     }
 }

src/Database/Database.php

@@ -1147,6 +1147,24 @@ public function setSharedTables(bool $sharedTables): static
         return $this;
     }
 
+    /**
+     * Set lock mode
+     *
+     * Set lock mode when altering tables
+     *
+     * @param bool $bool
+     * @return static
+     * @throws Exception
+     */
+    public function enableLocks(bool $bool): static
+    {
+        if ($this->adapter->getSupportForAlterLocks()) {
+            $this->adapter->enableLocks($bool);
+        }
+
+        return $this;
+    }
+
     /**
      * Set Tenant
      *

tests/e2e/Adapter/SharedTables/MariaDBTest.php

@@ -53,7 +53,9 @@ public function getDatabase(bool $fresh = false): Database
             ->setDatabase('utopiaTests')
             ->setSharedTables(true)
             ->setTenant(999)
-            ->setNamespace(static::$namespace = '');
+            ->setNamespace(static::$namespace = '')
+            ->enableLocks(true)
+        ;
 
         if ($database->exists()) {
             $database->delete();

tests/e2e/Adapter/SharedTables/MySQLTest.php

@@ -55,7 +55,9 @@ public function getDatabase(): Database
             ->setDatabase('utopiaTests')
             ->setSharedTables(true)
             ->setTenant(999)
-            ->setNamespace(static::$namespace = '');
+            ->setNamespace(static::$namespace = '')
+            ->enableLocks(true)
+        ;
 
         if ($database->exists()) {
             $database->delete();