Merge pull request #753 from utopia-php/fix-not-bound

Fix min/max not bound

Author: abnegate

src/Database/Adapter/MariaDB.php

@@ -1312,12 +1312,12 @@ public function increaseDocumentAttribute(
         $name = $this->filter($collection);
         $attribute = $this->filter($attribute);
 
-        $sqlMax = $max ? " AND `{$attribute}` <= {$max}" : '';
-        $sqlMin = $min ? " AND `{$attribute}` >= {$min}" : '';
+        $sqlMax = $max !== null ? " AND `{$attribute}` <= :max" : '';
+        $sqlMin = $min !== null ? " AND `{$attribute}` >= :min" : '';
 
         $sql = "
-			UPDATE {$this->getSQLTable($name)} 
-			SET 
+			UPDATE {$this->getSQLTable($name)}
+			SET
 			    `{$attribute}` = `{$attribute}` + :val,
 			    `_updatedAt` = :updatedAt
 			WHERE _uid = :_uid
@@ -1333,6 +1333,12 @@ public function increaseDocumentAttribute(
         $stmt->bindValue(':val', $value);
         $stmt->bindValue(':updatedAt', $updatedAt);
 
+        if ($max !== null) {
+            $stmt->bindValue(':max', $max);
+        }
+        if ($min !== null) {
+            $stmt->bindValue(':min', $min);
+        }
         if ($this->sharedTables) {
             $stmt->bindValue(':_tenant', $this->tenant);
         }

src/Database/Adapter/Mongo.php

@@ -1706,12 +1706,14 @@ public function increaseDocumentAttribute(string $collection, string $id, string
             $filters['_tenant'] = $this->getTenantFilters($collection);
         }
 
-        if ($max) {
-            $filters[$attribute] = ['$lte' => $max];
-        }
-
-        if ($min) {
-            $filters[$attribute] = ['$gte' => $min];
+        if ($max !== null || $min !== null) {
+            $filters[$attribute] = [];
+            if ($max !== null) {
+                $filters[$attribute]['$lte'] = $max;
+            }
+            if ($min !== null) {
+                $filters[$attribute]['$gte'] = $min;
+            }
         }
 
         $options = $this->getTransactionOptions();

src/Database/Adapter/Postgres.php

@@ -1433,12 +1433,12 @@ public function increaseDocumentAttribute(string $collection, string $id, string
         $name = $this->filter($collection);
         $attribute = $this->filter($attribute);
 
-        $sqlMax = $max ? " AND \"{$attribute}\" <= {$max}" : "";
-        $sqlMin = $min ? " AND \"{$attribute}\" >= {$min}" : "";
+        $sqlMax = $max !== null ? " AND \"{$attribute}\" <= :max" : "";
+        $sqlMin = $min !== null ? " AND \"{$attribute}\" >= :min" : "";
 
         $sql = "
-			UPDATE {$this->getSQLTable($name)} 
-			SET 
+			UPDATE {$this->getSQLTable($name)}
+			SET
 			    \"{$attribute}\" = \"{$attribute}\" + :val,
                 \"_updatedAt\" = :updatedAt
 			WHERE _uid = :_uid
@@ -1454,6 +1454,12 @@ public function increaseDocumentAttribute(string $collection, string $id, string
         $stmt->bindValue(':val', $value);
         $stmt->bindValue(':updatedAt', $updatedAt);
 
+        if ($max !== null) {
+            $stmt->bindValue(':max', $max);
+        }
+        if ($min !== null) {
+            $stmt->bindValue(':min', $min);
+        }
         if ($this->sharedTables) {
             $stmt->bindValue(':_tenant', $this->tenant);
         }