index, attribute filters, typo updates

Author: ArnabChatterjee20k

src/Database/Database.php

@@ -73,6 +73,7 @@ class Database
         ...self::SPATIAL_TYPES,
         self::VAR_VECTOR,
         self::VAR_OBJECT,
+        self::VAR_DATETIME
     ];
 
     // Index Types
@@ -2579,7 +2580,8 @@ public function updateAttribute(string $collection, string $id, ?string $type =
                         self::VAR_FLOAT,
                         self::VAR_BOOLEAN,
                         self::VAR_DATETIME,
-                        self::VAR_RELATIONSHIP . ', ' . self::VAR_OBJECT
+                        self::VAR_RELATIONSHIP,
+                        self::VAR_OBJECT
                     ];
                     if ($this->adapter->getSupportForVectors()) {
                         $supportedTypes[] = self::VAR_VECTOR;
@@ -3617,27 +3619,6 @@ public function createIndex(string $collection, string $id, string $type, array
             }
         }
 
-        if ($type === self::INDEX_OBJECT) {
-            if (count($attributes) !== 1) {
-                throw new IndexException('Object index can be created on a single object attribute');
-            }
-
-            foreach ($attributes as $attr) {
-                if (!isset($indexAttributesWithTypes[$attr])) {
-                    throw new IndexException('Attribute "' . $attr . '" not found in collection');
-                }
-
-                $attributeType = $indexAttributesWithTypes[$attr];
-                if ($attributeType !== self::VAR_OBJECT) {
-                    throw new IndexException('Object index can only be created on object attributes. Attribute "' . $attr . '" is of type "' . $attributeType . '"');
-                }
-            }
-
-            if (!empty($orders)) {
-                throw new IndexException('Object indexes do not support explicit orders. Remove the orders to create this index.');
-            }
-        }
-
         $index = new Document([
             '$id' => ID::custom($id),
             'key' => $id,

tests/e2e/Adapter/Scopes/AttributeTests.php

@@ -1750,16 +1750,23 @@ public function testCreateDatetime(): void
         }
     }
 
-    public function testCreateDateTimeAttributeFailure(): void
+    public function testCreateDatetimeAddingAutoFilter(): void
     {
         /** @var Database $database */
         $database = static::getDatabase();
 
-        $database->createCollection('datetime_fail');
+        $database->createCollection('datetime_auto_filter');
 
-        /** Test for FAILURE */
         $this->expectException(Exception::class);
-        $database->createAttribute('datetime_fail', 'date_fail', Database::VAR_DATETIME, 0, false);
+        $database->createAttribute('datetime_auto', 'date_auto', Database::VAR_DATETIME, 0, false, filters:['json']);
+        $collection = $database->getCollection('datetime_auto_filter');
+        $attribute = $collection->getAttributes()[0];
+        $this->assertEquals([Database::VAR_DATETIME,'json'], $attribute['filters']);
+        $database->updateAttribute('datetime_auto', 'date_auto', Database::VAR_DATETIME, 0, false, filters:[]);
+        $collection = $database->getCollection('datetime_auto_filter');
+        $attribute = $collection->getAttributes()[0];
+        $this->assertEquals([Database::VAR_DATETIME,'json'], $attribute['filters']);
+        $database->deleteCollection('datetime_auto_filter');
     }
     /**
      * @depends testCreateDeleteAttribute

tests/e2e/Adapter/Scopes/ObjectAttributeTests.php

@@ -652,7 +652,7 @@ public function testObjectAttributeGinIndex(): void
         } catch (\Exception $e) {
             $exceptionThrown = true;
             $this->assertInstanceOf(IndexException::class, $e);
-            $this->assertStringContainsString('Object indexes do not support explicit orders', $e->getMessage());
+            $this->assertStringContainsString('Object index do not support explicit orders', $e->getMessage());
         }
         $this->assertTrue($exceptionThrown, 'Expected Index exception for Object index with orders');
 

tests/e2e/Adapter/Scopes/VectorTests.php

@@ -2711,7 +2711,7 @@ public function testVectorQuerySum(): void
         $database->deleteCollection('vectorSum');
     }
 
-    public function testVetorUpsert(): void
+    public function testVectorUpsert(): void
     {
         /** @var Database $database */
         $database = static::getDatabase();

tests/unit/Validator/IndexTest.php

@@ -241,7 +241,7 @@ public function testEmptyAttributes(): void
     /**
      * @throws Exception
      */
-    public function testGinIndexValidation(): void
+    public function testObjectIndexValidation(): void
     {
         $collection = new Document([
             '$id' => ID::custom('test'),