fix: address review comments and fix test failures

- Wrap deleteCollection in try/catch for NotFoundException in duplicate recovery flow
- Remove dead $created condition (always true, flagged by PHPStan)
- Skip Sequence validation for $tenant attribute
- Use loose comparison for tenant checks to handle type mismatches

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: abnegate

src/Database/Database.php

@@ -1790,19 +1790,19 @@ public function createCollection(string $id, array $attributes = [], array $inde
             }
         }
 
-        $created = false;
-
         try {
             $this->adapter->createCollection($id, $attributes, $indexes);
-            $created = true;
         } catch (DuplicateException $e) {
             // Metadata check (above) already verified collection is absent
             // from metadata. A DuplicateException from the adapter means the
             // collection exists only in physical schema — an orphan from a prior
             // partial failure. Drop and recreate to ensure schema matches.
-            $this->adapter->deleteCollection($id);
+            try {
+                $this->adapter->deleteCollection($id);
+            } catch (NotFoundException) {
+                // Already removed by a concurrent reconciler.
+            }
             $this->adapter->createCollection($id, $attributes, $indexes);
-            $created = true;
         }
 
         if ($id === self::METADATA) {
@@ -1812,12 +1812,10 @@ public function createCollection(string $id, array $attributes = [], array $inde
         try {
             $createdCollection = $this->silent(fn () => $this->createDocument(self::METADATA, $collection));
         } catch (\Throwable $e) {
-            if ($created) {
-                try {
-                    $this->cleanupCollection($id);
-                } catch (\Throwable $e) {
-                    Console::error("Failed to rollback collection '{$id}': " . $e->getMessage());
-                }
+            try {
+                $this->cleanupCollection($id);
+            } catch (\Throwable $e) {
+                Console::error("Failed to rollback collection '{$id}': " . $e->getMessage());
             }
             throw new DatabaseException("Failed to create collection metadata for '{$id}': " . $e->getMessage(), previous: $e);
         }
@@ -1859,7 +1857,7 @@ public function updateCollection(string $id, array $permissions, bool $documentS
 
         if (
             $this->adapter->getSharedTables()
-            && $collection->getTenant() !== $this->adapter->getTenant()
+            && $collection->getTenant() != $this->adapter->getTenant()
         ) {
             throw new NotFoundException('Collection not found');
         }
@@ -1895,7 +1893,7 @@ public function getCollection(string $id): Document
             $id !== self::METADATA
             && $this->adapter->getSharedTables()
             && $collection->getTenant() !== null
-            && $collection->getTenant() !== $this->adapter->getTenant()
+            && $collection->getTenant() != $this->adapter->getTenant()
         ) {
             return new Document();
         }
@@ -1950,7 +1948,7 @@ public function getSizeOfCollection(string $collection): int
             throw new NotFoundException('Collection not found');
         }
 
-        if ($this->adapter->getSharedTables() && $collection->getTenant() !== $this->adapter->getTenant()) {
+        if ($this->adapter->getSharedTables() && $collection->getTenant() != $this->adapter->getTenant()) {
             throw new NotFoundException('Collection not found');
         }
 
@@ -1976,7 +1974,7 @@ public function getSizeOfCollectionOnDisk(string $collection): int
             throw new NotFoundException('Collection not found');
         }
 
-        if ($this->adapter->getSharedTables() && $collection->getTenant() !== $this->adapter->getTenant()) {
+        if ($this->adapter->getSharedTables() && $collection->getTenant() != $this->adapter->getTenant()) {
             throw new NotFoundException('Collection not found');
         }
 
@@ -2010,7 +2008,7 @@ public function deleteCollection(string $id): bool
             throw new NotFoundException('Collection not found');
         }
 
-        if ($this->adapter->getSharedTables() && $collection->getTenant() !== $this->adapter->getTenant()) {
+        if ($this->adapter->getSharedTables() && $collection->getTenant() != $this->adapter->getTenant()) {
             throw new NotFoundException('Collection not found');
         }
 
@@ -7204,7 +7202,7 @@ public function upsertDocumentsWithIncrease(
                     if ($document->getTenant() === null) {
                         throw new DatabaseException('Missing tenant. Tenant must be set when tenant per document is enabled.');
                     }
-                    if (!$old->isEmpty() && $old->getTenant() !== $document->getTenant()) {
+                    if (!$old->isEmpty() && $old->getTenant() != $document->getTenant()) {
                         throw new DatabaseException('Tenant cannot be changed.');
                     }
                 } else {

src/Database/Validator/Structure.php

@@ -340,6 +340,9 @@ protected function checkForInvalidAttributeValues(array $structure, array $keys)
 
             switch ($type) {
                 case Database::VAR_ID:
+                    if ($attribute['$id'] === '$tenant') {
+                        break;
+                    }
                     $validators[] = new Sequence($this->idAttributeType, $attribute['$id'] === '$sequence');
                     break;