Skip to content

Commit 34a22f0

Browse files
committed
Simplify the code around UUID variable definition
1 parent 92e83bf commit 34a22f0

1 file changed

Lines changed: 4 additions & 3 deletions

File tree

Makefile

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,15 +20,16 @@ TARGET_REPO=$(shell git ls-remote --get-url --symref $(TARGET_ORIGIN) | sed -e '
2020
TARGET_BRANCH=$(shell git rev-parse --abbrev-ref HEAD)
2121

2222
UUID_FILE ?= ~/.config/validated-patterns/pattern-uuid
23+
UUID_HELM_OPTS ?=
2324

2425
# --set values always take precedence over the contents of -f
2526
ifneq ("$(wildcard $(UUID_FILE))","")
2627
UUID := $(shell cat $(UUID_FILE))
27-
HELM_OPTS=-f values-global.yaml --set main.git.repoURL="$(TARGET_REPO)" --set main.git.revision=$(TARGET_BRANCH) $(TARGET_SITE_OPT) --set main.analyticsUUID=$(UUID) $(EXTRA_HELM_OPTS)
28-
else
29-
HELM_OPTS=-f values-global.yaml --set main.git.repoURL="$(TARGET_REPO)" --set main.git.revision=$(TARGET_BRANCH) $(TARGET_SITE_OPT) $(EXTRA_HELM_OPTS)
28+
UUID_HELM_OPTS := --set main.analyticsUUID=$(UUID)
3029
endif
3130

31+
HELM_OPTS=-f values-global.yaml --set main.git.repoURL="$(TARGET_REPO)" --set main.git.revision=$(TARGET_BRANCH) $(TARGET_SITE_OPT) $(UUID_HELM_OPTS) $(EXTRA_HELM_OPTS)
32+
3233

3334
##@ Pattern Common Tasks
3435

0 commit comments

Comments
 (0)