Skip to content

Commit 444016b

Browse files
mbaldessarimbaldessari
committed
Drop old comments
1 parent 65eab76 commit 444016b

4 files changed

Lines changed: 0 additions & 10 deletions

File tree

‎acm/templates/policies/application-policies.yaml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,8 @@ spec:
6161
value: {{ $.Values.global.hubClusterDomain }}
6262
- name: global.localClusterDomain
6363
value: '{{ `{{ (lookup "config.openshift.io/v1" "Ingress" "" "cluster").spec.domain }}` }}'
64-
# Requires ACM 2.6 or higher
6564
- name: global.clusterDomain
6665
value: '{{ `{{ (lookup "config.openshift.io/v1" "Ingress" "" "cluster").spec.domain | replace "apps." "" }}` }}'
67-
# Requires ACM 2.6 or higher (I could not come up with something less terrible to get maj.min)
6866
- name: global.clusterVersion
6967
value: '{{ `{{ printf "%d.%d" ((semver (index (lookup "config.openshift.io/v1" "ClusterVersion" "" "version").status.history 0).version).Major) ((semver (index (lookup "config.openshift.io/v1" "ClusterVersion" "" "version").status.history 0).version).Minor) }}` }}'
7068
- name: global.localClusterName

‎tests/acm-industrial-edge-hub.expected.yaml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -236,10 +236,8 @@ spec:
236236
value: apps.hub.example.com
237237
- name: global.localClusterDomain
238238
value: '{{ (lookup "config.openshift.io/v1" "Ingress" "" "cluster").spec.domain }}'
239-
# Requires ACM 2.6 or higher
240239
- name: global.clusterDomain
241240
value: '{{ (lookup "config.openshift.io/v1" "Ingress" "" "cluster").spec.domain | replace "apps." "" }}'
242-
# Requires ACM 2.6 or higher (I could not come up with something less terrible to get maj.min)
243241
- name: global.clusterVersion
244242
value: '{{ printf "%d.%d" ((semver (index (lookup "config.openshift.io/v1" "ClusterVersion" "" "version").status.history 0).version).Major) ((semver (index (lookup "config.openshift.io/v1" "ClusterVersion" "" "version").status.history 0).version).Minor) }}'
245243
- name: global.localClusterName

‎tests/acm-medical-diagnosis-hub.expected.yaml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -227,10 +227,8 @@ spec:
227227
value: apps.hub.example.com
228228
- name: global.localClusterDomain
229229
value: '{{ (lookup "config.openshift.io/v1" "Ingress" "" "cluster").spec.domain }}'
230-
# Requires ACM 2.6 or higher
231230
- name: global.clusterDomain
232231
value: '{{ (lookup "config.openshift.io/v1" "Ingress" "" "cluster").spec.domain | replace "apps." "" }}'
233-
# Requires ACM 2.6 or higher (I could not come up with something less terrible to get maj.min)
234232
- name: global.clusterVersion
235233
value: '{{ printf "%d.%d" ((semver (index (lookup "config.openshift.io/v1" "ClusterVersion" "" "version").status.history 0).version).Major) ((semver (index (lookup "config.openshift.io/v1" "ClusterVersion" "" "version").status.history 0).version).Minor) }}'
236234
- name: global.localClusterName

‎tests/acm-normal.expected.yaml‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -630,10 +630,8 @@ spec:
630630
value: apps.hub.example.com
631631
- name: global.localClusterDomain
632632
value: '{{ (lookup "config.openshift.io/v1" "Ingress" "" "cluster").spec.domain }}'
633-
# Requires ACM 2.6 or higher
634633
- name: global.clusterDomain
635634
value: '{{ (lookup "config.openshift.io/v1" "Ingress" "" "cluster").spec.domain | replace "apps." "" }}'
636-
# Requires ACM 2.6 or higher (I could not come up with something less terrible to get maj.min)
637635
- name: global.clusterVersion
638636
value: '{{ printf "%d.%d" ((semver (index (lookup "config.openshift.io/v1" "ClusterVersion" "" "version").status.history 0).version).Major) ((semver (index (lookup "config.openshift.io/v1" "ClusterVersion" "" "version").status.history 0).version).Minor) }}'
639637
- name: global.localClusterName
@@ -728,10 +726,8 @@ spec:
728726
value: apps.hub.example.com
729727
- name: global.localClusterDomain
730728
value: '{{ (lookup "config.openshift.io/v1" "Ingress" "" "cluster").spec.domain }}'
731-
# Requires ACM 2.6 or higher
732729
- name: global.clusterDomain
733730
value: '{{ (lookup "config.openshift.io/v1" "Ingress" "" "cluster").spec.domain | replace "apps." "" }}'
734-
# Requires ACM 2.6 or higher (I could not come up with something less terrible to get maj.min)
735731
- name: global.clusterVersion
736732
value: '{{ printf "%d.%d" ((semver (index (lookup "config.openshift.io/v1" "ClusterVersion" "" "version").status.history 0).version).Major) ((semver (index (lookup "config.openshift.io/v1" "ClusterVersion" "" "version").status.history 0).version).Minor) }}'
737733
- name: global.localClusterName

0 commit comments

Comments
 (0)