Skip to content

Commit 739a63b

Browse files
committed
Move the CLUSTERGROUP env variable for previews inside its section
This way the code is a bit less confusing and it's more obvious when/where CLUSTERGROUP is used. make preview-% still keeps working as usual and you can override things via `make CLUSTERGROUP=group-one preview-hello-world` Gotta love Makefile's idiosyncrasies around per-target variables
1 parent 37c93b0 commit 739a63b

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
NAME ?= $(shell basename "`pwd`")
2-
CLUSTERGROUP ?= $(shell yq ".main.clusterGroupName" values-global.yaml)
32

43
ifneq ($(origin TARGET_SITE), undefined)
54
TARGET_SITE_OPT=--set main.clusterGroupName=$(TARGET_SITE)
@@ -62,6 +61,7 @@ preview-all: ## (EXPERIMENTAL) Previews all applications on hub and managed clus
6261
@common/scripts/preview-all.sh $(TARGET_REPO) $(TARGET_BRANCH)
6362

6463
preview-%:
64+
$(eval CLUSTERGROUP ?= $(shell yq ".main.clusterGroupName" values-global.yaml))
6565
@common/scripts/preview.sh $(CLUSTERGROUP) $* $(TARGET_REPO) $(TARGET_BRANCH)
6666

6767
.PHONY: operator-deploy

0 commit comments

Comments
 (0)