Add check for syncPolicy.automated.allowEmpty and syncPolicy.automated.selfHeal

Author: sector2000

internal/controller/argo.go

@@ -978,6 +978,14 @@ func compareAutomatedSyncPolicy(goal, actual *argoapi.SyncPolicyAutomated) bool
 		log.Printf("SyncPolicy Prune changed %t -> %t\n", actual.Prune, goal.Prune)
 		return false
 	}
+	if goal.AllowEmpty != actual.AllowEmpty {
+		log.Printf("SyncPolicy AllowEmpty changed %t -> %t\n", actual.AllowEmpty, goal.AllowEmpty)
+		return false
+	}
+	if goal.SelfHeal != actual.SelfHeal {
+		log.Printf("SyncPolicy SelfHeal changed %t -> %t\n", actual.SelfHeal, goal.SelfHeal)
+		return false
+	}
 	return true
 }
 

internal/controller/argo_test.go

@@ -599,6 +599,28 @@ var _ = Describe("Argo Pattern", func() {
 				Expect(result).To(BeFalse())
 				Expect(logBuffer.String()).To(ContainSubstring("SyncPolicy Prune changed true -> false"))
 			})
+			It("should return false and log the appropriate message", func() {
+				automatedSyncPolicyChanged := automatedSyncPolicy.DeepCopy()
+				automatedSyncPolicyChanged.AllowEmpty = true
+				logBuffer := new(bytes.Buffer)
+				log.SetOutput(logBuffer)
+				defer log.SetOutput(os.Stderr)
+
+				result := compareAutomatedSyncPolicy(automatedSyncPolicy, automatedSyncPolicyChanged)
+				Expect(result).To(BeFalse())
+				Expect(logBuffer.String()).To(ContainSubstring("SyncPolicy AllowEmpty changed true -> false"))
+			})
+			It("should return false and log the appropriate message", func() {
+				automatedSyncPolicyChanged := automatedSyncPolicy.DeepCopy()
+				automatedSyncPolicyChanged.SelfHeal = true
+				logBuffer := new(bytes.Buffer)
+				log.SetOutput(logBuffer)
+				defer log.SetOutput(os.Stderr)
+
+				result := compareAutomatedSyncPolicy(automatedSyncPolicy, automatedSyncPolicyChanged)
+				Expect(result).To(BeFalse())
+				Expect(logBuffer.String()).To(ContainSubstring("SyncPolicy SelfHeal changed true -> false"))
+			})
 			It("compareAutomatedSyncPolicy() function with nil arg1", func() {
 				Expect(compareAutomatedSyncPolicy(automatedSyncPolicy, nil)).To(BeFalse())
 			})