add validation matrix for type-checking

Author: fswair

CONTRIBUTING.md

@@ -12,9 +12,12 @@ First off, thank you for considering contributing to this project!
 
 2. **Install dependencies using `uv`:**
    ```bash
-   uv venv
-   source .venv/bin/activate
-   uv pip install -e ".[dev]"
+   uv sync --extra dev --extra docs
+   ```
+
+   `pip` fallback:
+   ```bash
+   pip install -e ".[dev,docs]"
    ```
 
 3. **Install pre-commit hooks:**
@@ -26,12 +29,14 @@ First off, thank you for considering contributing to this project!
 
 We use a `Makefile` to simplify common tasks:
 
-- `make format`: Formats code using `ruff`.
-- `make check`: Runs linters (`ruff check`) and type checkers (`basedpyright`, `ty`).
-- `make tests`: Runs the test suite using `pytest`.
-- `make all`: Runs formatting and checking consecutively.
+- `make format`: Formats code using `uv run ruff format`.
+- `make check`: Runs the repo-default validation pass with `uv`.
+- `make check-matrix`: Runs `ruff`, `ty`, and `basedpyright` under Python `3.11`, `3.12`, and `3.13`.
+- `make tests`: Runs the test suite using `uv run pytest`.
+- `make all`: Runs `make format` then `make check`.
+- `make prod`: Runs `make tests`, `make format`, and `make check-matrix`.
 
-Before submitting a Pull Request, please ensure `make all` and `make tests` run without any errors.
+Before submitting a Pull Request, ensure `make prod` runs without errors.
 
 ## Pull Requests
 

Makefile

@@ -1,8 +1,9 @@
 BLUE := \033[1;34m
 GREEN := \033[1;32m
 RESET := \033[0m
+PYTHON_VERSIONS := 3.11 3.12 3.13
 
-.PHONY: tests format check all prod rename
+.PHONY: tests format check check-matrix all prod rename
 
 # Hack to allow passing arguments to make commands (e.g. make rename my_project)
 ifeq (rename,$(firstword $(MAKECMDGOALS)))
@@ -23,23 +24,32 @@ rename:
 
 format:
 	@printf "$(BLUE)==>$(RESET) Formatting code with ruff...\n"
-	@ruff format
+	@uv run ruff format
 	@printf "$(GREEN)✔ Formatting complete.$(RESET)\n"
 
 check:
-	@printf "$(BLUE)==>$(RESET) Running ruff checks and fixing issues...\n"
-	@ruff check --fix --unsafe-fixes
+	@printf "$(BLUE)==>$(RESET) Running ruff checks...\n"
+	@uv run ruff check
 	@printf "$(BLUE)==>$(RESET) Type checking with ty...\n"
-	@ty check
+	@uv run ty check
 	@printf "$(BLUE)==>$(RESET) Type checking with basedpyright...\n"
-	@basedpyright
+	@uv run basedpyright
 	@printf "$(GREEN)✔ Checking complete.$(RESET)\n"
 
+check-matrix:
+	@for version in $(PYTHON_VERSIONS); do \
+		printf "$(BLUE)==>$(RESET) Running validation matrix for Python $$version...\n"; \
+		uv run --python $$version ruff check src/vcode tests || exit $$?; \
+		uv run --python $$version ty check --python-version $$version || exit $$?; \
+		uv run --python $$version basedpyright --pythonversion $$version || exit $$?; \
+	done
+	@printf "$(GREEN)✔ Matrix checking complete.$(RESET)\n"
+
 tests:
 	@printf "$(BLUE)==>$(RESET) Running tests with pytest...\n"
-	@pytest
+	@uv run pytest
 	@printf "$(GREEN)✔ Tests complete.$(RESET)\n"
 
 all: format check
 
-prod: tests format check
+prod: tests format check-matrix

README.md

@@ -59,6 +59,16 @@ uv run basedpyright
 python3.11 -m pytest
 ```
 
+Current `Makefile` shortcuts:
+
+```bash
+make format
+make check
+make check-matrix
+make tests
+make prod
+```
+
 ## Documentation
 
 The detailed docs live under `docs/`.

tests/fakes.py

@@ -51,11 +51,11 @@ async def _test_model_response(
     del agent_info
     latest_message = messages[-1] if messages else None
     if isinstance(latest_message, ModelRequest):
-        tool_returns = [
-            part
-            for part in latest_message.parts
-            if getattr(part, "part_kind", None) == "tool-return"
-        ]
+        request_message = latest_message
+        tool_returns = []
+        for part in request_message.parts:
+            if getattr(part, "part_kind", None) == "tool-return":
+                tool_returns.append(part)
         if tool_returns:
             content = "\n".join(f"{part.tool_name}: {part.content}" for part in tool_returns)
             return ModelResponse(parts=[TextPart(content=content)], model_name="test:demo")