Skip to content

Commit 61d53a0

Browse files
committed
chore: remove unnecessary -y flag from CI (auto-detected)
1 parent e415d43 commit 61d53a0

2 files changed

Lines changed: 9 additions & 4 deletions

File tree

.github/workflows/test-standalone-install.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -657,7 +657,7 @@ jobs:
657657

658658
- name: Install via vp-setup.exe (silent)
659659
shell: pwsh
660-
run: ${{ format('{0}/target/release/vp-setup.exe', env.DEV_DRIVE) }} -y
660+
run: ${{ format('{0}/target/release/vp-setup.exe', env.DEV_DRIVE) }}
661661
env:
662662
VP_VERSION: alpha
663663

rfcs/windows-installer.md

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -167,12 +167,17 @@ Customization submenu:
167167

168168
### Silent Mode (CI)
169169

170+
The installer auto-detects CI environments (`CI=true`) and skips interactive prompts, so `-y` is not required in CI:
171+
170172
```bash
171-
# Accept all defaults
173+
# CI environments are automatically non-interactive
174+
vp-setup.exe
175+
176+
# Explicit silent mode (outside CI)
172177
vp-setup.exe -y
173178

174179
# Customize
175-
vp-setup.exe -y --version 0.3.0 --no-node-manager --registry https://registry.npmmirror.com
180+
vp-setup.exe --version 0.3.0 --no-node-manager --registry https://registry.npmmirror.com
176181
```
177182

178183
### CLI Flags
@@ -460,7 +465,7 @@ test-vp-setup-exe:
460465
run: cargo build --release -p vite_installer
461466
- name: Install via vp-setup.exe (silent)
462467
shell: pwsh
463-
run: ./target/release/vp-setup.exe -y
468+
run: ./target/release/vp-setup.exe
464469
env:
465470
VP_VERSION: alpha
466471
- name: Verify installation (pwsh/cmd/bash)

0 commit comments

Comments
 (0)