Skip to content

Commit 8ea9fed

Browse files
committed
adjust error message and fix typo
1 parent 8eab1ae commit 8ea9fed

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

crates/vite_global_cli/src/error.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ pub enum Error {
5656
Setup(#[from] vite_setup::error::Error),
5757

5858
#[error(
59-
"Node.js {version} does not meet vite-plus requirements ({requirement}).\nRun `vp env use 22` to switch to a compatible version."
59+
"Node.js {version} does not meet vite-plus requirements ({requirement}).\nRun `vp env use lts` to switch to a compatible version."
6060
)]
6161
NodeVersionIncompatible { version: String, requirement: String },
6262
}

crates/vite_global_cli/src/js_executor.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -443,7 +443,7 @@ fn check_runtime_compatibility(runtime: &JsRuntime, requirement: &str) -> Result
443443

444444
let normalized = version_str.strip_prefix('v').unwrap_or(version_str);
445445
let Ok(version) = Version::parse(normalized) else {
446-
return Ok(()); // unparseable version — skip silently
446+
return Ok(()); // unparsable version — skip silently
447447
};
448448
let Ok(range) = Range::parse(requirement) else {
449449
return Ok(()); // invalid range in package.json — skip silently
@@ -585,11 +585,11 @@ mod tests {
585585
}
586586

587587
#[test]
588-
fn unparseable_version_skips_check() {
588+
fn unparsable_version_skips_check() {
589589
let runtime = make_runtime_with_version("not-a-version");
590590
assert!(
591591
check_runtime_compatibility(&runtime, "^20.19.0 || >=22.12.0").is_ok(),
592-
"unparseable version should not cause an error"
592+
"unparsable version should not cause an error"
593593
);
594594
}
595595

0 commit comments

Comments
 (0)