chore(test): mark integration tests as ignored to decouple from Node.js setup (#341)

## Motivation

Two goals, both aimed at making the test suite behave more like standard
libtest and be easier for humans and AI agents to reason about:

1. **Default `cargo test` should pass with only the Rust toolchain.**
Tests that need Node.js or `pnpm install` are marked `#[ignore]` (or
`ignore = true` in an `[[e2e]]` TOML block). AI agents and new
contributors can run and iterate on tests without the extra setup; CI
runs the Rust-only tests first, then sets up Node/pnpm and runs the
ignored set.

2. **Trial names should look like standard libtest identifiers.** Every
fixture folder name and `[[e2e]] / [[plan]]` case name is now
`[A-Za-z0-9_]` only, so `cargo test
task_select::interactive_select_task` works without quoting, snapshot
filenames carry no whitespace, and the mapping between a trial name and
its on-disk fixture is obvious. A build-time assertion rejects any
future name that breaks the rule.

## Key Changes

- **One libtest-mimic trial per e2e case** (was one per fixture).
`run_case_inner` → `run_case` takes a single `E2e`, trials are named
`{fixture}::{case}`, and per-case staging dirs
(`{fixture}_case_{index}`) keep parallel trials isolated.

- **`snapshots.toml` loaded once per fixture** at trial-list build time
via a new `load_snapshots_file` helper. The per-case runner no longer
re-reads the file.

- **`ignore = true` under `[[e2e]]`** maps directly onto
`libtest_mimic::Trial::with_ignored_flag(...)`.

- **Node.js / pnpm-dependent tests marked `#[ignore]`**:
  - `crates/fspy/tests/node_fs.rs`: all 8 tests (need `node`)
- `crates/fspy/tests/oxlint.rs`: all 3 tests (need `oxlint` from
`packages/tools`)
-
`crates/vite_task_bin/tests/e2e_snapshots/fixtures/signal_exit/snapshots.toml`:
the single case that runs `node -e ...`

- **Fixture folder and case name normalization**: 35 e2e folders + 45
plan folders renamed (`task-select` → `task_select`, etc.); 149 e2e +
117 plan case names normalized (any non-`[A-Za-z0-9_]` → `_`); all
`.snap` / `.jsonc` files renamed in lock-step. Plan harness hardcoded
names updated: `"task graph"` → `"task_graph"`, `"task graph load
error"` → `"task_graph_load_error"`, `"query - {name}"` →
`"query_{name}"`.

- **Build-time guard**: both e2e and plan harnesses now call
`assert_identifier_like(...)` on fixture folder names and case names
during trial construction, so non-conforming entries fail loudly with a
clear message.

- **CI workflow reorder** (both the matrix `test` job and `test-musl`):
`cargo test --no-run` → `cargo test` → install Node.js + pnpm → `cargo
test -- --ignored`. The Rust-only run happens before Node/pnpm are on
PATH, enforcing the decoupling on every PR.

- **Docs**: `CONTRIBUTING.md` and `CLAUDE.md` describe the Rust-only
default and how to run the ignored subset (`cargo test --
--include-ignored` or `--ignored`) after `pnpm install` at the workspace
root (pnpm workspaces also install `packages/tools`).

## Implementation Details

- The `ignored` flag is applied via
`libtest_mimic::Trial::with_ignored_flag(bool)` — no reason string,
matching libtest-mimic's API.
- Platform filtering (`platform = "unix"` / `"windows"`) is now applied
during trial generation, so unmatched cases don't appear in the trial
list at all.
- A handful of gitignored fixture files (`dist/output.js`,
`node_modules/.bin/vt{,.cmd}`) needed `git add -f` at their new paths to
survive the folder rename.

https://claude.ai/code/session_01WHUFjqS6EbcoXp4UWHN1rj

---------

Co-authored-by: Claude <noreply@anthropic.com>

Author: branchseer

.github/workflows/ci.yml

@@ -123,6 +123,15 @@ jobs:
       - uses: mlugg/setup-zig@d1434d08867e3ee9daa34448df10607b98908d29 # v2
         if: ${{ matrix.target == 'x86_64-unknown-linux-gnu' }}
 
+      - name: Build tests
+        run: ${{ matrix.cargo_cmd }} test --no-run --target ${{ matrix.build_target }}
+
+      # Default `cargo test` runs only tests that need nothing beyond the
+      # Rust toolchain; this step verifies that contract before Node.js
+      # and pnpm enter the picture.
+      - name: Run tests
+        run: ${{ matrix.cargo_cmd }} test --target ${{ matrix.build_target }}
+
       # For x86_64-apple-darwin on arm64 runner, install x64 node so fspy preload dylib
       # (compiled for x86_64) can be injected into node processes running under Rosetta.
       # oxc-project/setup-node doesn't support the architecture input, so use
@@ -143,11 +152,8 @@ jobs:
       # Must run after setup-node so correct native binaries are installed
       - run: pnpm install
 
-      - name: Build tests
-        run: ${{ matrix.cargo_cmd }} test --no-run --target ${{ matrix.build_target }}
-
-      - name: Run tests
-        run: ${{ matrix.cargo_cmd }} test --target ${{ matrix.build_target }}
+      - name: Run ignored tests
+        run: ${{ matrix.cargo_cmd }} test --target ${{ matrix.build_target }} -- --ignored
 
   test-musl:
     needs: detect-changes
@@ -186,17 +192,23 @@ jobs:
       - name: Install Rust toolchain
         run: rustup show
 
-      - name: Install pnpm and Node tools
-        run: |
-          corepack enable
-          pnpm install
-
       - name: Build tests
         run: cargo test --no-run
 
+      # Default `cargo test` runs only tests that need nothing beyond the
+      # Rust toolchain; this step verifies that contract before pnpm
+      # populates `packages/tools/node_modules`.
       - name: Run tests
         run: cargo test
 
+      - name: Install pnpm and Node tools
+        run: |
+          corepack enable
+          pnpm install
+
+      - name: Run ignored tests
+        run: cargo test -- --ignored
+
   fmt:
     name: Format and Check Deps
     runs-on: namespace-profile-linux-x64-default

.typos.toml

@@ -8,5 +8,5 @@ extend-exclude = [
   "crates/fspy_detours_sys/src/generated_bindings.rs",
   # Intentional typos for testing fuzzy matching and "did you mean" suggestions
   "crates/vite_select/src/fuzzy.rs",
-  "crates/vite_task_bin/tests/e2e_snapshots/fixtures/task-select",
+  "crates/vite_task_bin/tests/e2e_snapshots/fixtures/task_select",
 ]

CLAUDE.md

@@ -23,27 +23,31 @@ async fn track_node_script(script: &str, args: &[&OsStr]) -> anyhow::Result<Path
 }
 
 #[test(tokio::test)]
+#[ignore = "requires node"]
 async fn read_sync() -> anyhow::Result<()> {
     let accesses = track_node_script("try { fs.readFileSync('hello') } catch {}", &[]).await?;
     assert_contains(&accesses, current_dir().unwrap().join("hello").as_path(), AccessMode::READ);
     Ok(())
 }
 
 #[test(tokio::test)]
+#[ignore = "requires node"]
 async fn exist_sync() -> anyhow::Result<()> {
     let accesses = track_node_script("try { fs.existsSync('hello') } catch {}", &[]).await?;
     assert_contains(&accesses, current_dir().unwrap().join("hello").as_path(), AccessMode::READ);
     Ok(())
 }
 
 #[test(tokio::test)]
+#[ignore = "requires node"]
 async fn stat_sync() -> anyhow::Result<()> {
     let accesses = track_node_script("try { fs.statSync('hello') } catch {}", &[]).await?;
     assert_contains(&accesses, current_dir().unwrap().join("hello").as_path(), AccessMode::READ);
     Ok(())
 }
 
 #[test(tokio::test)]
+#[ignore = "requires node"]
 async fn create_read_stream() -> anyhow::Result<()> {
     let accesses = track_node_script(
         "try { fs.createReadStream('hello').on('error', () => {}) } catch {}",
@@ -55,6 +59,7 @@ async fn create_read_stream() -> anyhow::Result<()> {
 }
 
 #[test(tokio::test)]
+#[ignore = "requires node"]
 async fn create_write_stream() -> anyhow::Result<()> {
     let tmpdir = tempfile::tempdir()?;
     let file_path = tmpdir.path().join("hello");
@@ -68,6 +73,7 @@ async fn create_write_stream() -> anyhow::Result<()> {
 }
 
 #[test(tokio::test)]
+#[ignore = "requires node"]
 async fn write_sync() -> anyhow::Result<()> {
     let tmpdir = tempfile::tempdir()?;
     let file_path = tmpdir.path().join("hello");
@@ -81,13 +87,15 @@ async fn write_sync() -> anyhow::Result<()> {
 }
 
 #[test(tokio::test)]
+#[ignore = "requires node"]
 async fn read_dir_sync() -> anyhow::Result<()> {
     let accesses = track_node_script("try { fs.readdirSync('.') } catch {}", &[]).await?;
     assert_contains(&accesses, &current_dir().unwrap(), AccessMode::READ_DIR);
     Ok(())
 }
 
 #[test(tokio::test)]
+#[ignore = "requires node"]
 async fn subprocess() -> anyhow::Result<()> {
     let cmd = if cfg!(windows) {
         r"'cmd', ['/c', 'type hello']"

CONTRIBUTING.md

@@ -52,6 +52,7 @@ async fn track_oxlint(dir: &std::path::Path, args: &[&str]) -> anyhow::Result<Pa
 }
 
 #[test(tokio::test)]
+#[ignore = "requires `pnpm install` (workspace root)"]
 async fn oxlint_reads_js_file() -> anyhow::Result<()> {
     let tmpdir = tempfile::tempdir()?;
     // on macOS, tmpdir.path() may be a symlink, so we need to canonicalize it
@@ -69,6 +70,7 @@ async fn oxlint_reads_js_file() -> anyhow::Result<()> {
 }
 
 #[test(tokio::test)]
+#[ignore = "requires `pnpm install` (workspace root)"]
 async fn oxlint_reads_directory() -> anyhow::Result<()> {
     let tmpdir = tempfile::tempdir()?;
 
@@ -84,6 +86,7 @@ async fn oxlint_reads_directory() -> anyhow::Result<()> {
 }
 
 #[test(tokio::test)]
+#[ignore = "requires `pnpm install` (workspace root)"]
 async fn oxlint_type_aware() -> anyhow::Result<()> {
     let tmpdir = tempfile::tempdir()?;
     // on macOS, tmpdir.path() may be a symlink, so we need to canonicalize it

crates/fspy/tests/node_fs.rs

@@ -1,7 +1,7 @@
 # Tests that tasks with identical commands share cache
 
 [[e2e]]
-name = "associate existing cache"
+name = "associate_existing_cache"
 steps = [
   { argv = [
     "vt",