From 11a7ae8ef26b50d52fcecbf3524028c1d851054f Mon Sep 17 00:00:00 2001 From: ZQlQZ Date: Wed, 3 Sep 2025 11:33:17 +0800 Subject: [PATCH] remove unnecessary return values --- tests/test_tos.py | 4 ++-- veadk/integrations/ve_tos/ve_tos.py | 20 ++++++++++---------- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/tests/test_tos.py b/tests/test_tos.py index f878864a..a680d7cc 100644 --- a/tests/test_tos.py +++ b/tests/test_tos.py @@ -108,7 +108,7 @@ async def test_upload_bytes_success(tos_client, mock_client): data = b"hello world" result = await tos_client.upload("obj-key", data) - assert result is True + assert result is None mock_client.put_object.assert_called_once() mock_client.close.assert_called_once() @@ -121,7 +121,7 @@ async def test_upload_file_success(tmp_path, tos_client, mock_client): file_path.write_text("hello file") result = await tos_client.upload("obj-key", str(file_path)) - assert result is True + assert result is None mock_client.put_object_from_file.assert_called_once() mock_client.close.assert_called_once() diff --git a/veadk/integrations/ve_tos/ve_tos.py b/veadk/integrations/ve_tos/ve_tos.py index 6bed9fcb..9d49f6c8 100644 --- a/veadk/integrations/ve_tos/ve_tos.py +++ b/veadk/integrations/ve_tos/ve_tos.py @@ -130,40 +130,40 @@ def upload( logger.error(error_msg) raise ValueError(error_msg) - def _do_upload_bytes(self, object_key: str, data: bytes) -> bool: + def _do_upload_bytes(self, object_key: str, data: bytes) -> None: try: if not self._client: - return False + return if not self.create_bucket(): - return False + return self._client.put_object( bucket=self.config.bucket_name, key=object_key, content=data ) logger.debug(f"Upload success, object_key: {object_key}") self._close() - return True + return except Exception as e: logger.error(f"Upload failed: {e}") self._close() - return False + return - def _do_upload_file(self, object_key: str, file_path: str) -> bool: + def _do_upload_file(self, object_key: str, file_path: str) -> None: try: if not self._client: - return False + return if not self.create_bucket(): - return False + return self._client.put_object_from_file( bucket=self.config.bucket_name, key=object_key, file_path=file_path ) self._close() logger.debug(f"Upload success, object_key: {object_key}") - return True + return except Exception as e: logger.error(f"Upload failed: {e}") self._close() - return False + return def download(self, object_key: str, save_path: str) -> bool: """download image from TOS"""