feat: wire enterprise conditions into rule evaluation pipeline

Register SignedCommitsCondition, ChangelogRequiredCondition,
NoSelfApprovalCondition, and CrossTeamApprovalCondition so the
ConditionRegistry can match them from YAML parameters and route
them through the fast condition-class evaluation path instead of
falling through to the LLM fallback.

- Add 4 RuleID enum values and violation text mappings
- Add entries to RULE_ID_TO_CONDITION and AVAILABLE_CONDITIONS
- Export from conditions/__init__.py
- Fix overly generic 'exceeded the' mapping key -> 'response SLA'
- Add missing test cases for all new and previously untested mappings

Author: dkargatzis

src/rules/acknowledgment.py

@@ -39,6 +39,10 @@ class RuleID(StrEnum):
     UNRESOLVED_COMMENTS = "unresolved-comments"
     TEST_COVERAGE = "test-coverage"
     COMMENT_RESPONSE_TIME = "comment-response-time"
+    SIGNED_COMMITS = "signed-commits"
+    CHANGELOG_REQUIRED = "changelog-required"
+    NO_SELF_APPROVAL = "no-self-approval"
+    CROSS_TEAM_APPROVAL = "cross-team-approval"
 
 
 # Mapping from violation text patterns to RuleID
@@ -58,7 +62,11 @@ class RuleID(StrEnum):
     "Security-sensitive patterns": RuleID.SECURITY_PATTERN,
     "unresolved review comment thread": RuleID.UNRESOLVED_COMMENTS,
     "without corresponding test changes": RuleID.TEST_COVERAGE,
-    "exceeded the": RuleID.COMMENT_RESPONSE_TIME,
+    "response SLA": RuleID.COMMENT_RESPONSE_TIME,
+    "unsigned commit": RuleID.SIGNED_COMMITS,
+    "without a corresponding CHANGELOG": RuleID.CHANGELOG_REQUIRED,
+    "approved by its own author": RuleID.NO_SELF_APPROVAL,
+    "approvals from required teams": RuleID.CROSS_TEAM_APPROVAL,
 }
 
 # Mapping from RuleID to human-readable descriptions
@@ -79,6 +87,10 @@ class RuleID(StrEnum):
     RuleID.UNRESOLVED_COMMENTS: "All review comments must be resolved before merging.",
     RuleID.TEST_COVERAGE: "Source code modifications must include corresponding test changes.",
     RuleID.COMMENT_RESPONSE_TIME: "Review comments must be addressed within the SLA timeframe.",
+    RuleID.SIGNED_COMMITS: "All commits in a pull request must be cryptographically signed.",
+    RuleID.CHANGELOG_REQUIRED: "Source code changes must include a CHANGELOG or .changeset update.",
+    RuleID.NO_SELF_APPROVAL: "PR authors cannot approve their own pull requests.",
+    RuleID.CROSS_TEAM_APPROVAL: "Pull requests require approvals from specified GitHub teams.",
 }
 
 # Comment markers that indicate an acknowledgment comment

src/rules/conditions/__init__.py

@@ -11,7 +11,15 @@
     ProtectedBranchesCondition,
     RequireCodeOwnerReviewersCondition,
 )
+from src.rules.conditions.access_control_advanced import (
+    CrossTeamApprovalCondition,
+    NoSelfApprovalCondition,
+)
 from src.rules.conditions.base import BaseCondition
+from src.rules.conditions.compliance import (
+    ChangelogRequiredCondition,
+    SignedCommitsCondition,
+)
 from src.rules.conditions.filesystem import (
     FilePatternCondition,
     MaxFileSizeCondition,
@@ -57,6 +65,12 @@
     "PathHasCodeOwnerCondition",
     "ProtectedBranchesCondition",
     "RequireCodeOwnerReviewersCondition",
+    # Access Control - Advanced
+    "NoSelfApprovalCondition",
+    "CrossTeamApprovalCondition",
+    # Compliance
+    "SignedCommitsCondition",
+    "ChangelogRequiredCondition",
     # Temporal
     "AllowedHoursCondition",
     "CommentResponseTimeCondition",

src/rules/registry.py

@@ -16,7 +16,15 @@
     ProtectedBranchesCondition,
     RequireCodeOwnerReviewersCondition,
 )
+from src.rules.conditions.access_control_advanced import (
+    CrossTeamApprovalCondition,
+    NoSelfApprovalCondition,
+)
 from src.rules.conditions.base import BaseCondition
+from src.rules.conditions.compliance import (
+    ChangelogRequiredCondition,
+    SignedCommitsCondition,
+)
 from src.rules.conditions.filesystem import (
     FilePatternCondition,
     MaxFileSizeCondition,
@@ -61,6 +69,10 @@
     RuleID.UNRESOLVED_COMMENTS: UnresolvedCommentsCondition,
     RuleID.TEST_COVERAGE: TestCoverageCondition,
     RuleID.COMMENT_RESPONSE_TIME: CommentResponseTimeCondition,
+    RuleID.SIGNED_COMMITS: SignedCommitsCondition,
+    RuleID.CHANGELOG_REQUIRED: ChangelogRequiredCondition,
+    RuleID.NO_SELF_APPROVAL: NoSelfApprovalCondition,
+    RuleID.CROSS_TEAM_APPROVAL: CrossTeamApprovalCondition,
 }
 
 # Reverse map: condition class -> RuleID (for populating rule_id on violations)
@@ -90,6 +102,10 @@
     SecurityPatternCondition,
     UnresolvedCommentsCondition,
     TestCoverageCondition,
+    NoSelfApprovalCondition,
+    CrossTeamApprovalCondition,
+    SignedCommitsCondition,
+    ChangelogRequiredCondition,
 ]
 
 

tests/unit/rules/test_acknowledgment.py

@@ -35,8 +35,8 @@ def test_all_rule_ids_are_strings(self):
             assert len(rule_id.value) > 0
 
     def test_rule_id_count(self):
-        """Verify we have exactly 16 standardized rule IDs."""
-        assert len(RuleID) == 16
+        """Verify we have exactly 20 standardized rule IDs."""
+        assert len(RuleID) == 20
 
     def test_all_rule_ids_have_descriptions(self):
         """Every RuleID should have a corresponding description."""
@@ -160,6 +160,15 @@ class TestMapViolationTextToRuleId:
             ("Restricted patterns ['console'] found in added lines of src/app.js", RuleID.DIFF_PATTERN),
             ("Security-sensitive patterns ['api_key'] detected in src/auth.py", RuleID.SECURITY_PATTERN),
             ("PR has 1 unresolved review comment thread(s)", RuleID.UNRESOLVED_COMMENTS),
+            ("Source files were modified without corresponding test changes.", RuleID.TEST_COVERAGE),
+            ("2 review thread(s) have exceeded the 24-hour response SLA.", RuleID.COMMENT_RESPONSE_TIME),
+            ("Found 3 unsigned commit(s): abc1234, def5678, ghi9012", RuleID.SIGNED_COMMITS),
+            (
+                "Source code was modified without a corresponding CHANGELOG update.",
+                RuleID.CHANGELOG_REQUIRED,
+            ),
+            ("Pull request was approved by its own author.", RuleID.NO_SELF_APPROVAL),
+            ("Missing approvals from required teams: @org/security, @org/qa", RuleID.CROSS_TEAM_APPROVAL),
         ],
     )
     def test_maps_violation_text_correctly(self, text: str, expected_rule_id: RuleID):