Skip to content

Commit 5ef9db1

Browse files
committed
fix: rename GITHUB_WEBHOOK_SECRET to WEBHOOK_SECRET_GITHUB
- Change environment variable name to comply with GitHub naming restrictions - Update variable references across .env.example, helm values, and config - Fix GitHub Actions workflow to use correct secret name - Update validation error messages in config.py Signed-off-by: Dimitris Kargatzis <dkargatzis@gmail.com>
1 parent 9e93291 commit 5ef9db1

4 files changed

Lines changed: 5 additions & 5 deletions

File tree

.env.example

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,4 @@ PRIVATE_KEY_BASE64_GITHUB=
2424
REDIRECT_URI_GITHUB=http://localhost:3000
2525

2626
# GitHub Webhook Configuration
27-
GITHUB_WEBHOOK_SECRET=
27+
WEBHOOK_SECRET_GITHUB=

.github/workflows/eks-deploy.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ jobs:
6767
--set secrets.CLIENT_ID_GITHUB=${{ secrets.CLIENT_ID_GITHUB }} \
6868
--set secrets.APP_CLIENT_SECRET=${{ secrets.APP_CLIENT_SECRET }} \
6969
--set secrets.PRIVATE_KEY_BASE64_GITHUB=${{ secrets.PRIVATE_KEY_BASE64_GITHUB }} \
70-
--set secrets.GITHUB_WEBHOOK_SECRET=${{ secrets.GITHUB_WEBHOOK_SECRET }} \
70+
--set secrets.WEBHOOK_SECRET_GITHUB=${{ secrets.WEBHOOK_SECRET_GITHUB }} \
7171
--set secrets.OPENAI_API_KEY=${{ secrets.OPENAI_API_KEY }} \
7272
--set secrets.LANGCHAIN_API_KEY=${{ secrets.LANGCHAIN_API_KEY }} \
7373
--set secrets.LANGCHAIN_PROJECT=${{ secrets.LANGCHAIN_PROJECT }} \

helm-chart/values.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ secrets:
7474
CLIENT_ID_GITHUB: ""
7575
APP_CLIENT_SECRET: ""
7676
PRIVATE_KEY_BASE64_GITHUB: ""
77-
GITHUB_WEBHOOK_SECRET: ""
77+
WEBHOOK_SECRET_GITHUB: ""
7878
OPENAI_API_KEY: ""
7979
LANGCHAIN_API_KEY: ""
8080
LANGCHAIN_PROJECT: ""

src/core/config.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ def __init__(self):
7676
app_id=os.getenv("CLIENT_ID_GITHUB", ""),
7777
app_client_secret=os.getenv("APP_CLIENT_SECRET", ""),
7878
private_key=os.getenv("PRIVATE_KEY_BASE64_GITHUB", ""),
79-
webhook_secret=os.getenv("GITHUB_WEBHOOK_SECRET", ""),
79+
webhook_secret=os.getenv("WEBHOOK_SECRET_GITHUB", ""),
8080
)
8181

8282
self.ai = AIConfig(
@@ -143,7 +143,7 @@ def validate(self) -> bool:
143143
errors.append("PRIVATE_KEY_BASE64_GITHUB is required")
144144

145145
if not self.github.webhook_secret:
146-
errors.append("GITHUB_WEBHOOK_SECRET is required")
146+
errors.append("WEBHOOK_SECRET_GITHUB is required")
147147

148148
if self.ai.provider == "openai" and not self.ai.api_key:
149149
errors.append("OPENAI_API_KEY is required for OpenAI provider")

0 commit comments

Comments
 (0)