cluster: get all vms with -A/--all

Author: weizhouapache

Development.md

@@ -4,9 +4,12 @@ Kubernetes-style declarative orchestration tool for Apache CloudStack
 ## Build & Install
 
 ```bash
-# Build binary
+# Build binary for CLI
 go build -o cloudstackctl main.go
 
+# Build binary for Controller (if run locally)
+go build -o cloudstackctl-controller cmd/controller
+
 # Install to PATH
 sudo mv cloudstackctl /usr/local/bin/
 ```

README.md

@@ -8,7 +8,8 @@ For local development configuration see [Development.md](Development.md).
 
 # Architecture Overview
 
-* Single `cloudstackctl` binary provides the CLI and controller runtime.
+* Single `cloudstackctl` binary provides the CLI.
+* Single `cloudstackctl-controller` binary provides the API server and controller runtime.
 * Controller sends async requests to CloudStack API, writes desired & observed state, manages health checks and dependency graph. It exposes a small health endpoint on port `65426` (`/health`).
 * CLI operates locally and uses the CloudStack client to perform direct actions when appropriate; credentials are loaded from a config file (see `-c`) or environment variables (`.env.cloudstack` is used by default if present).
 

cmd/cli/get.go

@@ -50,6 +50,9 @@ var getCmd = &cobra.Command{
 		// Cluster mode: forward to controller HTTP API (/list)
 		var endpoint = "/list"
 		q := url.Values{}
+		if getAll && resourceType == "VirtualMachine" {
+			q.Set("all", "true")
+		}
 		q.Set("kind", resourceType)
 		if name != "" {
 			q.Set("name", name)
@@ -61,7 +64,7 @@ var getCmd = &cobra.Command{
 		}
 
 		// If controller returned VM objects from DB, pretty-print them
-		if resourceType == "VirtualMachine" {
+		if resourceType == "VirtualMachine" && !getAll {
 			var vms []v1.VirtualMachine
 			if err := json.Unmarshal(body, &vms); err == nil {
 				handlers.PrintVMsFromDB(vms)
@@ -77,22 +80,25 @@ func init() {
 	rootCmd.AddCommand(getCmd)
 }
 
+var getAll bool
+
+func init() {
+	getCmd.Flags().BoolVarP(&getAll, "all", "A", false, "Show all VMs from CloudStack (include unmanaged) — cluster mode only")
+}
+
 // tryDecodeAndPrint attempts to decode controller JSON into known typed
 // responses and prints them using the shared handlers. Returns true if
 // printing was performed.
 func tryDecodeAndPrint(resourceType string, body []byte) bool {
-	// VMs are returned from the controller DB as []v1.VirtualMachine
-	if resourceType == "VirtualMachine" {
-		var vms []v1.VirtualMachine
-		if err := json.Unmarshal(body, &vms); err == nil {
-			handlers.PrintVMsFromDB(vms)
-			return true
-		}
-	}
-
 	// Try CloudStack SDK response types for unmanaged resources so we can
 	// preserve typed slices (e.g., []*cs.Network) when printing.
 	switch resourceType {
+	case "VirtualMachine":
+		var resp cs.ListVirtualMachinesResponse
+		if err := json.Unmarshal(body, &resp); err == nil {
+			handlers.PrintCloudStackResource(resourceType, &resp)
+			return true
+		}
 	case "Network":
 		var resp cs.ListNetworksResponse
 		if err := json.Unmarshal(body, &resp); err == nil {

controller/controller.go

@@ -272,6 +272,27 @@ func (c *Controller) Start() {
 				w.Write(b)
 				return
 			case "VirtualMachine":
+				// If client requested all VMs, delegate to handlers which will
+				// query CloudStack directly. This preserves parity with
+				// standalone mode when `--all` is used in the CLI.
+				if r.URL.Query().Get("all") == "true" {
+					payload := map[string]string{"kind": "VirtualMachine"}
+					if name != "" {
+						payload["name"] = name
+					}
+					raw, _ := json.Marshal(payload)
+					obj, err := handlers.GetCloudStackResource(raw)
+					if err != nil {
+						http.Error(w, fmt.Sprintf("failed to list VirtualMachine: %v", err), http.StatusInternalServerError)
+						return
+					}
+					b, _ := json.Marshal(obj)
+					w.Header().Set("Content-Type", "application/json")
+					w.WriteHeader(http.StatusOK)
+					w.Write(b)
+					return
+				}
+
 				var vms []v1.VirtualMachine
 				if db.DB == nil {
 					http.Error(w, "database unavailable", http.StatusServiceUnavailable)

go.mod

@@ -3,7 +3,7 @@ module cloudstackctl
 go 1.26
 
 require (
-	github.com/apache/cloudstack-go/v2 v2.19.1-0.20260314202825-5fe04df62a24
+	github.com/apache/cloudstack-go/v2 v2.19.1-0.20260315154432-66bc95151dde
 	github.com/spf13/cobra v1.10.2
 	gorm.io/driver/postgres v1.6.0
 	gorm.io/gorm v1.31.1

go.sum

@@ -1,9 +1,7 @@
 github.com/Masterminds/semver/v3 v3.4.0 h1:Zog+i5UMtVoCU8oKka5P7i9q9HgrJeGzI9SA1Xbatp0=
 github.com/Masterminds/semver/v3 v3.4.0/go.mod h1:4V+yj/TJE1HU9XfppCwVMZq3I84lprf4nC11bSS5beM=
-github.com/apache/cloudstack-go/v2 v2.19.1-0.20260314200611-0d1a4d5d553d h1:FszupfrdjfiPihpvlTYIhPqFEUIVwhX03x5C3q3KLJQ=
-github.com/apache/cloudstack-go/v2 v2.19.1-0.20260314200611-0d1a4d5d553d/go.mod h1:p/YBUwIEkQN6CQxFhw8Ff0wzf1MY0qRRRuGYNbcb1F8=
-github.com/apache/cloudstack-go/v2 v2.19.1-0.20260314202825-5fe04df62a24 h1:20hiJBwNKgbEXt2rBNJhAVurt8cn4xQMzcLU/TN+IWY=
-github.com/apache/cloudstack-go/v2 v2.19.1-0.20260314202825-5fe04df62a24/go.mod h1:p/YBUwIEkQN6CQxFhw8Ff0wzf1MY0qRRRuGYNbcb1F8=
+github.com/apache/cloudstack-go/v2 v2.19.1-0.20260315154432-66bc95151dde h1:pk4w1j9l674UkU/acmHWrRNilUC2tgzDDt9ScfLIOxE=
+github.com/apache/cloudstack-go/v2 v2.19.1-0.20260315154432-66bc95151dde/go.mod h1:p/YBUwIEkQN6CQxFhw8Ff0wzf1MY0qRRRuGYNbcb1F8=
 github.com/cpuguy83/go-md2man/v2 v2.0.6/go.mod h1:oOW0eioCTA6cOiMLiUPZOpcVxMig6NIQQ7OS05n1F4g=
 github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E=
 github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38=