Fix color or links in dark mode on custom themes (#25391)

Author: kean

RELEASE-NOTES.txt

@@ -10,6 +10,7 @@
 * [*] Stats: Usability improvements [#25404]
 * [*] Reader: Fix an issue with pan gesture failing to dismiss Lightbox [#25372]
 * [*] Reader: Fix color of links in comments [#25390]
+* [*] Reader: Fix color or links in dark mode on custom themes [#25391]
 * [*] Reader: Add support for viewing media galleries fullscreen with a way to swipe between images [#25365]
 * [*] Notifications: Fix navigational buttons spacing [#25401]
 * [*] [internal] Fix retain cycle in Reader Article screen [#25364]

WordPress/Classes/ViewRelated/Reader/Detail/WebView/ReaderWebView.swift

@@ -216,6 +216,7 @@ class ReaderWebView: WKWebView {
         """
     }
 
+    // TODO: remove `reader-full-post.reader-full-post__story-content` from-mobile-reader.css on Calypso when this fixed is shipped on the app level
     private func overrideStyles() -> String {
         /// Some context: We are fetching the CSS file from a remote endpoint, but we store a local `reader.css` file
         /// to override some styles for mobile-specific purposes.
@@ -233,6 +234,13 @@ class ReaderWebView: WKWebView {
                 font-weight: \(displaySetting.color == .system ? "inherit" : "600");
                 text-decoration: underline;
             }
+
+            /* workaround for CMM-1964 */
+            .reader-full-post.reader-full-post__story-content {
+                a {
+                    color: var(--main-link-color);
+                }
+            }
         """
     }
 
@@ -314,12 +322,12 @@ class ReaderWebView: WKWebView {
     }
 
     func linkColor(for trait: UITraitCollection) -> UIColor {
-        let color = displaySetting.color == .system ? UIAppColor.blue : displaySetting.color.foreground
+        let color = displaySetting.color == .system ? UIAppColor.link : displaySetting.color.foreground
         return color.color(for: trait)
     }
 
     func activeLinkColor(for trait: UITraitCollection) -> UIColor {
-        let color = displaySetting.color == .system ? UIAppColor.blue(.shade30) : displaySetting.color.secondaryForeground
+        let color = displaySetting.color == .system ? UIAppColor.link : displaySetting.color.secondaryForeground
         return color.color(for: trait)
     }
 }