fix: leak fixing retain cycle of GutenbergCoverUploadProcessor (#25455)

kean · amanjeetsingh150 · web-flow · commit 570a22935b66 · 2026-03-27T01:35:18.000Z
Co-authored-by: amanjeetsingh150 &lt;amanjeetsingh150@gmail.com&gt;
diff --git a/WordPress/Classes/ViewRelated/Gutenberg/Processors/GutenbergCoverUploadProcessor.swift b/WordPress/Classes/ViewRelated/Gutenberg/Processors/GutenbergCoverUploadProcessor.swift
@@ -22,9 +22,10 @@ class GutenbergCoverUploadProcessor: Processor {
         self.remoteURLString = remoteURLString
     }
 
-    lazy var coverBlockProcessor = GutenbergBlockProcessor(for: CoverBlockKeys.name, replacer: { coverBlock in
-        guard let mediaID = coverBlock.attributes[CoverBlockKeys.id] as? Int,
-            mediaID == self.mediaUploadID else {
+    lazy var coverBlockProcessor = GutenbergBlockProcessor(for: CoverBlockKeys.name, replacer: { [weak self] coverBlock in
+        guard let self,
+              let mediaID = coverBlock.attributes[CoverBlockKeys.id] as? Int,
+              mediaID == self.mediaUploadID else {
                 return nil
         }
         var block = "<!-- \(CoverBlockKeys.name) "

Original file line number	Diff line number	Diff line change
`@@ -22,9 +22,10 @@ class GutenbergCoverUploadProcessor: Processor {`
`22`	`22`	`self.remoteURLString = remoteURLString`
`23`	`23`	`}`
`24`	`24`
`25`		`- lazy var coverBlockProcessor = GutenbergBlockProcessor(for: CoverBlockKeys.name, replacer: { coverBlock in`
`26`		`- guard let mediaID = coverBlock.attributes[CoverBlockKeys.id] as? Int,`
`27`		`- mediaID == self.mediaUploadID else {`
	`25`	`+ lazy var coverBlockProcessor = GutenbergBlockProcessor(for: CoverBlockKeys.name, replacer: { [weak self] coverBlock in`
	`26`	`+ guard let self,`
	`27`	`+ let mediaID = coverBlock.attributes[CoverBlockKeys.id] as? Int,`
	`28`	`+ mediaID == self.mediaUploadID else {`
`28`	`29`	`return nil`
`29`	`30`	`}`
`30`	`31`	`var block = "<!-- \(CoverBlockKeys.name) "`