Skip to content

Commit 8b51f6d

Browse files
authored
Fix an issue with empty state not disappearing on Reader Comments view after you post a comment (#25484)
1 parent d7992d3 commit 8b51f6d

4 files changed

Lines changed: 4 additions & 1 deletion

File tree

RELEASE-NOTES.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
* [*] Reader: Fix an issue with "Notificaton Settings" showing incorrect state right after subscribing [#25459]
99
* [*] Reader: Fix an issue with "Notificaton Settings" button shown when you are not subscribed [#25459]
1010
* [*] Reader: Fix a regression with anchors not working in posts [#25459]
11+
* [*] Reader: Fix an issue with empty state not disappearing on Reader Comments view after you post a comment [#25484]
1112
* [*] Reader: Fix an issues with Reader failing to clear cached comments if all the comments are deleted [#25482]
1213
* [*] Reader: Fix an issue with the article view removing autoplay without showing controls [#25468]
1314
* [*] Menus: Fix an issue with footer view in Menu Editing not resizing [#25481]

WordPress/Classes/ViewRelated/Notifications/Views/CommentLargeButton.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ final class CommentLargeButton: UIView {
4040
backgroundColor = .systemBackground
4141

4242
addSubview(leaveCommentView)
43+
leaveCommentView.displaySettings = .standard
4344
leaveCommentView.pinEdges(to: safeAreaLayoutGuide, insets: UIEdgeInsets.init(top: 14, left: 20, bottom: 8, right: 20))
4445

4546
let divider = SeparatorView.horizontal()

WordPress/Classes/ViewRelated/Reader/Comments/ReaderCommentsTableViewController.swift

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,7 @@ final class ReaderCommentsTableViewController: UIViewController, UITableViewData
179179
UIView.performWithoutAnimation {
180180
tableView.endUpdates()
181181
}
182+
containerViewController?.refreshEmptyStateView()
182183
}
183184

184185
// MARK: - UITableViewDataSource

WordPress/Classes/ViewRelated/Reader/Comments/ReaderCommentsViewController.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -203,7 +203,7 @@ final class ReaderCommentsViewController: UIViewController, WPContentSyncHelperD
203203
navigationItem.rightBarButtonItem = post.isSubscribedComments ? barButtonItemFollowingSettings : barButtonItemFollowConversation
204204
}
205205

206-
private func refreshEmptyStateView() {
206+
func refreshEmptyStateView() {
207207
activityIndicator.stopAnimating()
208208

209209
emptyStateView?.removeFromSuperview()

0 commit comments

Comments
 (0)