fix: listEnvironmentRoles should not use PaginatedResource (#341)

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: csrbarber

lib/RBAC.php

@@ -183,33 +183,22 @@ public function createEnvironmentRole(
     /**
      * List Environment Roles.
      *
-     * @param int $limit Maximum number of records to return
-     * @param null|string $before Role ID to look before
-     * @param null|string $after Role ID to look after
-     * @param null|string $order The order in which to paginate records
-     *
      * @throws Exception\WorkOSException
      *
-     * @return Resource\PaginatedResource
+     * @return Resource\Role[]
      */
-    public function listEnvironmentRoles(
-        int $limit = self::DEFAULT_PAGE_SIZE,
-        ?string $before = null,
-        ?string $after = null,
-        ?string $order = null
-    ) {
+    public function listEnvironmentRoles()
+    {
         $path = "authorization/roles";
 
-        $params = [
-            "limit" => $limit,
-            "before" => $before,
-            "after" => $after,
-            "order" => $order,
-        ];
+        $response = Client::request(Client::METHOD_GET, $path, null, null, true);
 
-        $response = Client::request(Client::METHOD_GET, $path, null, $params, true);
+        $roles = [];
+        foreach ($response["data"] as $responseData) {
+            \array_push($roles, Resource\Role::constructFromResponse($responseData));
+        }
 
-        return Resource\PaginatedResource::constructFromResponse($response, Resource\Role::class, 'roles');
+        return $roles;
     }
 
     /**

tests/WorkOS/RBACTest.php

@@ -170,26 +170,19 @@ public function testListEnvironmentRoles()
 
         $result = $this->rolesListResponseFixture();
 
-        $params = [
-            "limit" => RBAC::DEFAULT_PAGE_SIZE,
-            "before" => null,
-            "after" => null,
-            "order" => null,
-        ];
-
         $this->mockRequest(
             Client::METHOD_GET,
             $path,
             null,
-            $params,
+            null,
             true,
             $result
         );
 
         $role = $this->roleFixture();
 
-        $response = $this->rbac->listEnvironmentRoles();
-        $this->assertSame($role, $response->roles[0]->toArray());
+        $roles = $this->rbac->listEnvironmentRoles();
+        $this->assertSame($role, $roles[0]->toArray());
     }
 
     public function testGetEnvironmentRole()
@@ -552,10 +545,6 @@ private function rolesListResponseFixture()
                     "created_at" => "2024-01-01T00:00:00.000Z",
                     "updated_at" => "2024-01-01T00:00:00.000Z"
                 ]
-            ],
-            "list_metadata" => [
-                "before" => null,
-                "after" => null
             ]
         ]);
     }