Skip to content

Commit 626f8c7

Browse files
matttbegregkh
authored andcommitted
scripts/decode_stacktrace.sh: symbol: avoid trailing whitespaces
commit d322f6a24ee5964a58294f61bf96a1b6404c676d upstream. A few patches slightly improving the output generated by decode_stacktrace.sh. This patch (of 3): Lines having a symbol to decode might not always have info after this symbol. It means ${info_str} might not be set, but it will always be printed after a space, causing trailing whitespaces. That's a detail, but when the output is opened with an editor marking these trailing whitespaces, that's a bit disturbing. It is easy to remove them by printing this variable with a space only if it is set. While at it, do the same with ${module} and print everything in one line. Link: https://lkml.kernel.org/r/20250908-decode_strace_indent-v1-0-28e5e4758080@kernel.org Link: https://lkml.kernel.org/r/20250908-decode_strace_indent-v1-1-28e5e4758080@kernel.org Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org> Reviewed-by: Carlos Llamas <cmllamas@google.com> Reviewed-by: Breno Leitao <leitao@debian.org> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> Cc: Carlos Llamas <cmllamas@google.com> Cc: Elliot Berman <quic_eberman@quicinc.com> Cc: Stephen Boyd <swboyd@chromium.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent a2b5df4 commit 626f8c7

1 file changed

Lines changed: 1 addition & 6 deletions

File tree

scripts/decode_stacktrace.sh

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -323,12 +323,7 @@ handle_line() {
323323
parse_symbol # modifies $symbol
324324

325325
# Add up the line number to the symbol
326-
if [[ -z ${module} ]]
327-
then
328-
echo "${words[@]}" "$symbol ${info_str}"
329-
else
330-
echo "${words[@]}" "$symbol $module ${info_str}"
331-
fi
326+
echo "${words[@]}" "${symbol}${module:+ ${module}}${info_str:+ ${info_str}}"
332327
}
333328

334329
while read line; do

0 commit comments

Comments
 (0)