Skip to content

Commit fd6f991

Browse files
meritissimo1gregkh
authored andcommitted
xfs: Replace strncpy with memcpy
[ Upstream commit 33ddc796ecbd50cd6211aa9e9eddbf4567038b49 ] The changes modernizes the code by aligning it with current kernel best practices. It improves code clarity and consistency, as strncpy is deprecated as explained in Documentation/process/deprecated.rst. This change does not alter the functionality or introduce any behavioral changes. Suggested-by: Dave Chinner <david@fromorbit.com> Reviewed-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com> Signed-off-by: Marcelo Moreira <marcelomoreira1905@gmail.com> Reviewed-by: Darrick J. Wong <djwong@kernel.org> Signed-off-by: Carlos Maiolino <cem@kernel.org> Stable-dep-of: 678e1cc2f482 ("xfs: fix out of bounds memory read error in symlink repair") Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 3e1c43f commit fd6f991

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/xfs/scrub/symlink_repair.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,7 @@ xrep_symlink_salvage_inline(
185185
return 0;
186186

187187
nr = min(XFS_SYMLINK_MAXLEN, xfs_inode_data_fork_size(ip));
188-
strncpy(target_buf, ifp->if_data, nr);
188+
memcpy(target_buf, ifp->if_data, nr);
189189
return nr;
190190
}
191191

0 commit comments

Comments
 (0)