Skip to content

Commit 6b0c965

Browse files
authored
Merge pull request #316 from ynput/bugfix/fix-headers-handling
Upload: Fix headers handling
2 parents e1716a6 + b8b5fad commit 6b0c965

2 files changed

Lines changed: 4 additions & 7 deletions

File tree

ayon_api/_api.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1276,7 +1276,6 @@ def upload_reviewable(
12761276
content_type: Optional[str] = None,
12771277
filename: Optional[str] = None,
12781278
progress: Optional[TransferProgress] = None,
1279-
headers: Optional[dict[str, Any]] = None,
12801279
**kwargs,
12811280
) -> requests.Response:
12821281
"""Upload reviewable file to server.
@@ -1291,7 +1290,6 @@ def upload_reviewable(
12911290
filename (Optional[str]): User as original filename. Filename from
12921291
'filepath' is used when not filled.
12931292
progress (Optional[TransferProgress]): Progress.
1294-
headers (Optional[dict[str, Any]]): Headers.
12951293
12961294
Returns:
12971295
requests.Response: Server response.
@@ -1306,7 +1304,6 @@ def upload_reviewable(
13061304
content_type=content_type,
13071305
filename=filename,
13081306
progress=progress,
1309-
headers=headers,
13101307
**kwargs,
13111308
)
13121309

ayon_api/server_api.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1792,7 +1792,10 @@ def _upload_file(
17921792
url = self._endpoint_to_url(endpoint, use_rest=False)
17931793
progress.set_destination_url(url)
17941794

1795-
headers = kwargs.setdefault("headers", {})
1795+
headers = kwargs.get("headers")
1796+
if headers is None:
1797+
kwargs["headers"] = headers = {}
1798+
17961799
headers_keys_by_low_key = {key.lower(): key for key in headers}
17971800
if self._session is None:
17981801
for key, value in self.get_headers().items():
@@ -1982,7 +1985,6 @@ def upload_reviewable(
19821985
content_type: Optional[str] = None,
19831986
filename: Optional[str] = None,
19841987
progress: Optional[TransferProgress] = None,
1985-
headers: Optional[dict[str, Any]] = None,
19861988
**kwargs
19871989
) -> requests.Response:
19881990
"""Upload reviewable file to server.
@@ -1997,7 +1999,6 @@ def upload_reviewable(
19971999
filename (Optional[str]): User as original filename. Filename from
19982000
'filepath' is used when not filled.
19992001
progress (Optional[TransferProgress]): Progress.
2000-
headers (Optional[dict[str, Any]]): Headers.
20012002
20022003
Returns:
20032004
requests.Response: Server response.
@@ -2026,7 +2027,6 @@ def upload_reviewable(
20262027
progress=progress,
20272028
content_type=content_type,
20282029
filename=filename,
2029-
headers=headers,
20302030
request_type=RequestTypes.post,
20312031
**kwargs
20322032
)

0 commit comments

Comments
 (0)