chore: add standardized NetworkAccountNoteAllowlist slot for network account detection#2883
Merged
PhilippGackstatter merged 10 commits intonextfrom May 8, 2026
Merged
Conversation
PhilippGackstatter
added
the
pr-from-maintainers
PhilippGackstatter
requested review from
Mirko-von-Leipzig,
bobbinth and
partylikeits1983
and removed request for
bobbinth
Contributor
Author
|
After addressing @Mirko-von-Leipzig's comment, I noticed that we're using |
bobbinth
approved these changes
May 7, 2026
Contributor
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I reviewed mostly non-test code and left one non-blocking comment inline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added standardized
NetworkAccountNoteAllowlistslot for detecting network accounts as part of #2285. The motivation for this was outlined in #2817 (comment).This is the first of two (?) steps towards removing
AccountStorageMode::Network.Also implements reconstructing such a storage slot from account storage. This would eventually use
AccountStorageInterface(#2623).Changes internal representation to use
NoteScriptRootfor more type safety.Requesting review from @Mirko-von-Leipzig mainly for the overall approach, not necessarily the details, though a review is of course appreciated 🙂