Add MethodImplAttributes.Async flag#571
Open
PhilippNaused wants to merge 1 commit into
Open
Conversation
Contributor
|
"Async methods also do not have matching return type conventions as sync methods. For sync methods, the stack should contain a value convertible to the stated return type before the @wtfsck What do you think? |
Author
|
@ElektroKill Like this? /// <summary>
/// <c>true</c> if the method returns a value (i.e., return type is not <see cref="System.Void"/>)
/// </summary>
+/// <remarks>
+/// <see cref="MethodImplAttributes.Async"/> methods also do not have matching return type conventions as sync methods.
+/// For sync methods, the stack should contain a value convertible to the stated return type before the <see cref="OpCodes.Ret"/> instruction.
+/// For async methods, the stack should be empty in the case of <c>Task</c> or <c>ValueTask</c>, or the type argument in the case of <c>Task<T></c> or <c>ValueTask<T></c>.
+/// <seealso href="https://github.com/dotnet/runtime/blob/main/docs/design/specs/runtime-async.md"/>
+/// </remarks>
public bool HasReturnType => ReturnType.RemovePinnedAndModifiers().GetElementType() != ElementType.Void; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the new Async flag for methods that was introduced for the new Runtime-Async Feature in .NET 11.
See:
https://github.com/dotnet/runtime/blob/main/docs/design/specs/runtime-async.md
https://github.com/dotnet/runtime/blob/0c7ef81aa7d25dcac00eb81d156e03f4c0ca396b/src/coreclr/inc/corhdr.h#L650
https://github.com/dotnet/runtime/blob/0c7ef81aa7d25dcac00eb81d156e03f4c0ca396b/src/libraries/System.Private.CoreLib/src/System/Reflection/MethodImplAttributes.cs#L34