Add functions to delay AzureLogHandler instantiation. (#137)

Author: MarcusRisanger

datareservoirio/_logging.py

@@ -1,6 +1,6 @@
 import logging
 import os
-from functools import wraps
+from functools import wraps, cache
 
 from opencensus.ext.azure.log_exporter import AzureLogHandler
 
@@ -9,18 +9,20 @@
 from ._constants import ENV_VAR_ENABLE_APP_INSIGHTS, ENV_VAR_ENGINE_ROOM_APP_ID
 from .globalsettings import environment
 
-exceptions_logger = logging.getLogger(__name__ + "_exception_logger")
-exceptions_logger.setLevel(logging.DEBUG)
-
-if os.getenv(ENV_VAR_ENABLE_APP_INSIGHTS) is not None:
-    enable_app_insights = os.environ[ENV_VAR_ENABLE_APP_INSIGHTS].lower()
-    if enable_app_insights == "true" or enable_app_insights == "1":
-        app_insight_handler = AzureLogHandler(
-            connection_string=environment._application_insight_connectionstring
-        )
-        app_insight_handler.setLevel("WARNING")
-        exceptions_logger.addHandler(app_insight_handler)
-
+@cache
+def get_exceptions_logger() -> logging.Logger:
+    exceptions_logger = logging.getLogger(__name__ + "_exception_logger")
+    exceptions_logger.setLevel(logging.DEBUG)
+
+    if os.getenv(ENV_VAR_ENABLE_APP_INSIGHTS) is not None:
+        enable_app_insights = os.environ[ENV_VAR_ENABLE_APP_INSIGHTS].lower()
+        if enable_app_insights == "true" or enable_app_insights == "1":
+            app_insight_handler = AzureLogHandler(
+                connection_string=environment._application_insight_connectionstring
+            )
+            app_insight_handler.setLevel("WARNING")
+            exceptions_logger.addHandler(app_insight_handler)
+    return exceptions_logger
 
 def log_decorator(log_level):
     def decorator(func):
@@ -39,7 +41,7 @@ def wrapper(self, *args, **kwargs):
                         ENV_VAR_ENGINE_ROOM_APP_ID
                     )
 
-                log_function = getattr(exceptions_logger, log_level)
+                log_function = getattr(get_exceptions_logger(), log_level)
                 log_function(e, extra=properties)
                 raise e
 

datareservoirio/client.py

@@ -4,7 +4,7 @@
 from collections import defaultdict
 from concurrent.futures import ThreadPoolExecutor
 from datetime import datetime
-from functools import wraps
+from functools import wraps, cache
 from operator import itemgetter
 from urllib.parse import urlencode
 from uuid import uuid4
@@ -29,11 +29,14 @@
 
 log = logging.getLogger(__name__)
 
-metric = logging.getLogger(__name__ + "_metric_appinsight")
-metric.setLevel(logging.DEBUG)
-metric.addHandler(
-    AzureLogHandler(connection_string=environment._application_insight_connectionstring)
-)
+@cache
+def metric() -> logging.Logger:
+    logger = logging.getLogger(__name__ + "_metric_appinsight")
+    logger.setLevel(logging.DEBUG)
+    logger.addHandler(
+        AzureLogHandler(connection_string=environment._application_insight_connectionstring)
+    )
+    return logger
 
 # Default values to push as start/end dates. (Limited by numpy.datetime64)
 _END_DEFAULT = 9214646400000000000  # 2262-01-01
@@ -329,7 +332,7 @@ def wrapper(self, series_id, start=None, end=None, **kwargs):
                     "number-of-samples": number_of_samples,
                 }
             }
-            metric.info("Timer", extra=properties)
+            metric().info("Timer", extra=properties)
             return result
 
         return wrapper