IRecursiveParent<T>.Children returns IReadOnlyCollection

AArnott · AArnott · commit cc1bef951eba · 2016-07-04T07:18:45.000-06:00
diff --git a/src/ImmutableObjectGraph.Generation/CodeGen+EnumerableRecursiveParentGen.cs b/src/ImmutableObjectGraph.Generation/CodeGen+EnumerableRecursiveParentGen.cs
@@ -164,11 +164,11 @@ private void ImplementRecursiveParentInterface()
                             SyntaxFactory.Argument(SyntaxFactory.MemberAccessExpression(SyntaxKind.SimpleMemberAccessExpression, parentedVar, SyntaxFactory.IdentifierName(nameof(ParentedRecursiveTypeNonGeneric.Value)))),
                             SyntaxFactory.Argument(SyntaxFactory.MemberAccessExpression(SyntaxKind.SimpleMemberAccessExpression, parentedVar, SyntaxFactory.IdentifierName(nameof(ParentedRecursiveTypeNonGeneric.Parent)))))))));
 
-                ////System.Collections.Generic.IEnumerable<<#= templateType.RecursiveType.TypeName #>> IRecursiveParent<<#= templateType.RecursiveType.TypeName #>>.Children
+                ////System.Collections.Generic.IReadOnlyCollection<<#= templateType.RecursiveType.TypeName #>> IRecursiveParent<<#= templateType.RecursiveType.TypeName #>>.Children
                 ////	=> return this.Children;
                 this.innerMembers.Add(
                     SyntaxFactory.PropertyDeclaration(
-                        Syntax.IEnumerableOf(this.generator.applyToMetaType.RecursiveType.TypeSyntax),
+                        Syntax.IReadOnlyCollectionOf(this.generator.applyToMetaType.RecursiveType.TypeSyntax),
                         nameof(IRecursiveParent<IRecursiveType>.Children))
                     .WithExplicitInterfaceSpecifier(SyntaxFactory.ExplicitInterfaceSpecifier(irecursiveParentOfT))
                     .WithExpressionBody(SyntaxFactory.ArrowExpressionClause(thisDotChildren))
diff --git a/src/ImmutableObjectGraph.Generation/CodeGen+RootedStructGen.cs b/src/ImmutableObjectGraph.Generation/CodeGen+RootedStructGen.cs
@@ -752,8 +752,8 @@ protected PropertyDeclarationSyntax[] CreateChildrenProperties()
                                 Syntax.ThisDot(GreenNodeFieldName),
                                 this.applyTo.RecursiveParent.RecursiveField.NameAsProperty)))
                         .WithSemicolonToken(SyntaxFactory.Token(SyntaxKind.SemicolonToken)),
-                    // IEnumerable<TRootedRecursiveType> IRecursiveParent<TRootedRecursiveType>.Children { get; }
-                    SyntaxFactory.PropertyDeclaration(Syntax.IEnumerableOf(this.rootedRecursiveType), nameof(IRecursiveParent<IRecursiveType>.Children))
+                    // IReadOnlyCollection<TRootedRecursiveType> IRecursiveParent<TRootedRecursiveType>.Children { get; }
+                    SyntaxFactory.PropertyDeclaration(Syntax.IReadOnlyCollectionOf(this.rootedRecursiveType), nameof(IRecursiveParent<IRecursiveType>.Children))
                         .WithExplicitInterfaceSpecifier(SyntaxFactory.ExplicitInterfaceSpecifier(CreateIRecursiveParentOfTSyntax(this.rootedRecursiveType)))
                         // => this.Children;
                         .WithExpressionBody(SyntaxFactory.ArrowExpressionClause(Syntax.ThisDot(this.applyTo.RecursiveParent.RecursiveField.NameAsProperty)))
diff --git a/src/ImmutableObjectGraph/IRecursiveCollection.cs b/src/ImmutableObjectGraph/IRecursiveCollection.cs
@@ -20,7 +20,7 @@ public interface IRecursiveParent : IRecursiveType {
 
 	public interface IRecursiveParent<out TRecursiveType> : IRecursiveParent
 		where TRecursiveType : IRecursiveType {
-		new IEnumerable<TRecursiveType> Children { get; }
+		new IReadOnlyCollection<TRecursiveType> Children { get; }
 	}
 
     public interface IRecursiveParentWithChildReplacement<TRecursiveType> : IRecursiveParent

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ public interface IRecursiveParent : IRecursiveType {`
`20`	`20`
`21`	`21`	`public interface IRecursiveParent<out TRecursiveType> : IRecursiveParent`
`22`	`22`	`where TRecursiveType : IRecursiveType {`
`23`		`- new IEnumerable<TRecursiveType> Children { get; }`
	`23`	`+ new IReadOnlyCollection<TRecursiveType> Children { get; }`
`24`	`24`	`}`
`25`	`25`
`26`	`26`	`public interface IRecursiveParentWithChildReplacement<TRecursiveType> : IRecursiveParent`