Update trampoline to use official spec values#2819
Draft
t-bast wants to merge 4 commits into
Draft
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2819 +/- ##
==========================================
+ Coverage 85.80% 86.04% +0.23%
==========================================
Files 236 237 +1
Lines 21299 21842 +543
Branches 859 841 -18
==========================================
+ Hits 18275 18793 +518
- Misses 3024 3049 +25
🚀 New features to boost your workflow:
|
t-bast
force-pushed
the
trampoline-spec-version
branch
from
ee178c7 to
bd76a24
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
from
bd76a24 to
d33f661
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
2 times, most recently
from
cd8e468 to
3f459d3
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
from
b781e95 to
3d5a8fe
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
6 times, most recently
from
90fb0c1 to
c333cd4
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
3 times, most recently
from
18dc4e1 to
d2ad160
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
from
d2ad160 to
68d8aa2
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
2 times, most recently
from
0e91113 to
d405c1a
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
from
d405c1a to
0e7d664
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
2 times, most recently
from
ddbe7f0 to
7d669ff
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
from
7d669ff to
d7739eb
Compare
t-bast
force-pushed
the
trampoline-spec-version
branch
2 times, most recently
from
292d906 to
f1fa4b1
Compare
We add support for the official version of trampoline payments, as specified in lightning/bolts#836. We keep supporting trampoline payments that use the legacy protocol to allow a smooth transition. We hardcode the legacy feature bit 149 in a few places to make this work, which is a bit hacky but simple and should be removed 6 months after releasing the official version. We also keep supporting payments from trampoline wallets to nodes that don't support trampoline: this is bad from a privacy standpoint, but will be fixed when recipients start supporting Bolt 12.
We add support for trampoline payments to blinded recipients, where each node of the blinded path is used as trampoline node. This is particularly useful to include custom TLVs from the payer to the recipient.
t-bast
force-pushed
the
trampoline-spec-version
branch
2 times, most recently
from
e468df9 to
8afa8bd
Compare
When returning trampoline failures for the payer (the creator of the trampoline onion), they must be encrypted using the sphinx shared secret of the trampoline onion. When relaying a trampoline payment, we re-wrap the (peeled) trampoline onion inside a payment onion: if we receive a failure for the outgoing payment, it can be either coming from before the next trampoline node or after them. If it's coming from before, we can decrypt that error using the shared secrets we created for the payment onion: depending on the error, we can then return our own error to the payer. If it's coming from after the next trampoline onion, it will be encrypted for the payer, so we cannot decrypt it. We must peel the shared secrets of our payment onion, and then re-encrypted with the shared secret of the incoming trampoline onion. This way only the payer will be able to decrypt the failure, which is relayed back through each intermediate trampoline node.
We add APIs to allow e2e and cross-compat tests for sending trampoline payments for Bolt11 invoices or Bolt12 offers. This commit should be reverted before merging, as we don't want to expose sending trampoline payments to real eclair nodes. Bolt11 invoices can be created with: eclair-cli createinvoice --amountMsat=<amount_msat> --description="trampoline rocks" Bolt11 invoices can be paid using trampoline with: eclair-cli payinvoicetrampoline --invoice=<bolt11_invoice> --trampolineNodeId=<node_id> --amountMsat=<optional_amount_msat> Bolt12 offers that don't use a blinded path (directly expose the offerer's node_id) can be created with: eclair-cli createoffer Bolt12 offers that use a blinded path for the offer can be created with (where usually the trampoline node is used as blindedPathsFirstNodeId): eclair-cli createoffer --blindedPathsFirstNodeId=<node_id> Bolt12 offers can be paid using trampoline with: eclair-cli payoffertrampoline --offer=<bolt12_offer> --trampolineNodeId=<node_id> --amountMsat=<optional_amount_msat> Note that the sending node must have direct channels with the trampoline node (for this simplified sender-side support). Also note that error handling and retries aren't properly implemented: fixed fee and expiry increments are used for simplicity (TrampolinePaymentLifecycle.scala).
t-bast
force-pushed
the
trampoline-spec-version
branch
from
8afa8bd to
1f12d65
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the feature bit and tlvs defined in the official spec PR (lightning/bolts#836) and add support for:
We also add the official spec test vectors.
We keep backwards-compatibility for current wallet users relying on the legacy trampoline protocol, but will likely drop support at some point. We should notify the Electrum folks and give them enough time to migrate to the new protocol before dropping support for the legacy one.