Fix PowerShell command failure status#2109
Open
snoopuppy582 wants to merge 1 commit into
Open
Conversation
Signed-off-by: snoopuppy582 <mnb0968@naver.com>
|
|
Contributor
|
@snoopuppy582 was this issue tackled as part of devdays, or independently? Thank you. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2109 +/- ##
==========================================
- Coverage 60.65% 60.64% -0.01%
==========================================
Files 164 164
Lines 20584 20584
Branches 3579 3579
==========================================
- Hits 12485 12483 -2
- Misses 7224 7225 +1
- Partials 875 876 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
This was independent. I saw #2073, reproduced the PowerShell status issue locally on Windows, and opened the PR with the focused regression test for that case. Thanks for checking. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
$?before checkingLASTEXITCODEin generated PowerShell startup scriptsLASTEXITCODEpowershellandpwshTest plan
pytest src/rez/tests/test_shells.py::TestShells::test_powershell_command_not_found_returncode -qpytest src/rez/tests/test_shells.py::TestShells::test_pwsh_lastexitcode_gui -qflake8 src/rezplugins/shell/_utils/powershell_base.py src/rez/tests/test_shells.pyexecute_shellcheck: missing command returns 1 forpowershellandpwsh;hello_world -q -r 66still returns 66 for bothCloses #2073