[codex] Restore parse model serialization#1381
Open
pragnyanramtha wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
model_to_dictsupport for raw response objects that exposeparse()__dict__when parsing fails or returns itselfRoot cause
safe_serializealready routed objects withparse()intomodel_to_dict, and the helper docstring promised raw API response support, but the parse branch was commented out after recursion problems. Those objects fell through to__dict__, which could lose the parsed response payload expected by instrumentation code.Validation
uv run pytest tests/unit/test_serialization.py -quv run ruff check agentops/helpers/serialization.py tests/unit/test_serialization.pyNote:
uv run --locked ...currently fails because the checked-inuv.lockwants to be rewritten by this uv version; this PR intentionally leaves the lockfile untouched.