test: add dedicated test coverage for diffs.py module#5009
Open
1Ckpwee wants to merge 1 commit intoAider-AI:mainfrom
Open
test: add dedicated test coverage for diffs.py module#50091Ckpwee wants to merge 1 commit intoAider-AI:mainfrom
1Ckpwee wants to merge 1 commit intoAider-AI:mainfrom
Conversation
Cover all public functions: create_progress_bar, assert_newlines, find_last_non_deleted, and diff_partial_update. Tests include edge cases for empty content, identical content, new file creation, file deletion, backtick escaping, progress bar rendering, and fname headers.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aider/diffs.pyhandles streaming diff display but had no dedicated tests. This PR adds 27 tests covering the module's public API.Test coverage added
create_progress_bar()(4 tests): 0%, 50%, 100%, fractional percentagesassert_newlines()(5 tests): empty list, valid lines, last-line tolerance, missing newline / empty string raisesfind_last_non_deleted()(7 tests): identical content, partial updates, changed lines, no common lines, empty inputsdiff_partial_update()(11 tests): empty return on no common lines, diff block rendering, final vs streaming mode, fname headers, new file creation, file deletion, backtick escaping, progress bar percentage, output formattingTest plan
pytest tests/basic/test_diffs.py -v— 0.03s)