DPL: use new indices methods to navigate through InputRecord in output-proxy#15270
Merged
ehellbar merged 1 commit intoAliceO2Group:devfrom Apr 11, 2026
Merged
DPL: use new indices methods to navigate through InputRecord in output-proxy#15270ehellbar merged 1 commit intoAliceO2Group:devfrom
ehellbar merged 1 commit intoAliceO2Group:devfrom
Conversation
Collaborator
Author
|
@ktf here I don't know what the intention of the loop and looping direction was in the first place, so I tried to keep it like that using the new methods you implemented when you refactored the InputRecord. the old loop and methods were simply way to slow after we went away from the MessageSet, it was simply hidden before by the issues and slow-down we had in the QC task in front. I might also check the code if there are other places (e.g. detector code) which look suspicious. |
Collaborator
Author
|
also, if there is a more elegant way to do this that I don't see right now, please let me know :) |
Member
|
This is to solve a performance regression in the proxy, correct? LGTM for now. |
ktf
approved these changes
Apr 10, 2026
Collaborator
Author
|
yes, the regression is in the dpl-output-proxy. Thank you for reviewing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.