Set readOnly to 'nocursor' in markdown editor#2041
Closed
isaachilly wants to merge 1 commit intomainfrom
Closed
Conversation
Using 'nocursor' when readOnly is true, ensures the blinking caret is hidden avoiding confusion if editing or not.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2041 +/- ##
==========================================
+ Coverage 45.47% 45.61% +0.14%
==========================================
Files 1023 1023
Lines 17053 17054 +1
Branches 3092 3093 +1
==========================================
+ Hits 7754 7780 +26
+ Misses 9299 9274 -25 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Houwie7000
approved these changes
Dec 11, 2025
graduta
requested changes
Dec 12, 2025
Member
graduta
left a comment
There was a problem hiding this comment.
Hi @isaachilly . The idea is good but by not allowing the cursor, the copy-paint functionality will not work anymore on Firefox and Chrome.
It does work on Safari, but we have to support all 3 browsers. If not easy solution is found, I would propose for the PR to be closed without merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using 'nocursor' when readOnly is true, ensures the blinking caret is hidden.
For example, on log entries, focussing on the log text will make a blinking caret appear, I believe this is too similar behaviour to that of editing/creating an entry and is disconcerting.
I DON'T have JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: