[O2B-1489] Update table and page height constants#2042
Closed
isaachilly wants to merge 2 commits intomainfrom
Closed
[O2B-1489] Update table and page height constants#2042isaachilly wants to merge 2 commits intomainfrom
isaachilly wants to merge 2 commits intomainfrom
Conversation
Adjusted TABLEROW_HEIGHT and PAGE_USED_HEIGHT to reflect updated UI dimensions.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2042 +/- ##
=======================================
Coverage 45.47% 45.47%
=======================================
Files 1023 1023
Lines 17053 17053
Branches 3092 3092
=======================================
Hits 7754 7754
Misses 9299 9299 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Adjusted test expectations to reflect a change in the row heights and used page height.
graduta
requested changes
Dec 12, 2025
| import { filtersPanelPopover } from '../../../components/Filters/common/filtersPanelPopover.js'; | ||
|
|
||
| const TABLEROW_HEIGHT = 58; | ||
| const TABLEROW_HEIGHT = 65.3; |
Member
There was a problem hiding this comment.
To me the browser still displays a size of 57.6 (~58). How did you come to this new value?
| const TABLEROW_HEIGHT = 65.3; | ||
| // Estimate of the navbar and pagination elements height total; Needs to be updated in case of changes; | ||
| const PAGE_USED_HEIGHT = 181; | ||
| const PAGE_USED_HEIGHT = 260; |
Member
There was a problem hiding this comment.
Same here, the browser estimate is around 181, but in my tests an 185 is better as we have paddings in rem values. A 260 is way too big.
Collaborator
Author
|
See ticket: https://its.cern.ch/jira/browse/O2B-1516 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjusted TABLEROW_HEIGHT and PAGE_USED_HEIGHT to reflect updated UI dimensions.
Forgot to do when first completing the ticket.
I have a JIRA ticket
Notable changes for users:
Notable changes for developers:
Changes made to the database: