Skip to content

Commit 91b24a5

Browse files
committed
Simplify QC CheckInterface
1 parent 5e8278d commit 91b24a5

3 files changed

Lines changed: 20 additions & 20 deletions

File tree

include/QualityControl/CheckInterface.h

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,17 +27,17 @@ class CheckInterface
2727
{
2828
public:
2929
/// Default constructor
30-
CheckInterface();
30+
CheckInterface() = default;
3131
/// Destructor
32-
virtual ~CheckInterface();
32+
virtual ~CheckInterface() = default;
3333

3434
/// \brief Configure the check based on its name.
3535
///
3636
/// The configuration of the object can't be done in the constructor because
3737
/// ROOT needs an argument-less constructor when streaming it. We use this method
3838
/// to configure the object. The name might be used to ask the configuration system
3939
/// for specific parameters.
40-
virtual void configure(std::string name);
40+
virtual void configure(std::string name) = 0;
4141

4242
/// \brief Returns the quality associated with this object.
4343
///
@@ -68,8 +68,8 @@ class CheckInterface
6868

6969
bool isObjectCheckable(const MonitorObject *mo);
7070

71-
private:
72-
std::string mName;
71+
// private:
72+
// std::string mName;
7373

7474
ClassDef(CheckInterface, 1)
7575
};

include/QualityControl/MonitorObject.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@ class MonitorObject : public TObject
4141
/// Copy constructor
4242
MonitorObject (const MonitorObject& other) = default;
4343
/// Move constructor
44-
MonitorObject (MonitorObject&& other) noexcept = default;
44+
MonitorObject (MonitorObject&& other) /*noexcept*/ = default;
4545
/// Copy assignment operator
4646
MonitorObject& operator= (const MonitorObject& other) = default;
4747
/// Move assignment operator
48-
MonitorObject& operator= (MonitorObject&& other) noexcept = default;
48+
MonitorObject& operator= (MonitorObject&& other) /*noexcept*/ = default;
4949

5050
const std::string &getName() const
5151
{

src/CheckInterface.cxx

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -15,19 +15,19 @@ namespace AliceO2 {
1515
namespace QualityControl {
1616
namespace Checker {
1717

18-
CheckInterface::CheckInterface()
19-
: mName("")
20-
{
21-
}
22-
23-
CheckInterface::~CheckInterface()
24-
{
25-
}
26-
27-
void CheckInterface::configure(std::string name)
28-
{
29-
mName = name;
30-
}
18+
//CheckInterface::CheckInterface()
19+
//// : mName("")
20+
//{
21+
//}
22+
//
23+
//CheckInterface::~CheckInterface()
24+
//{
25+
//}
26+
27+
//void CheckInterface::configure(std::string name)
28+
//{
29+
// mName = name;
30+
//}
3131

3232
std::string CheckInterface::getAcceptedType()
3333
{

0 commit comments

Comments
 (0)