Antalya 26.3 Backport of #99935 - Support more flexible data paths validation in iceberg#1769
Open
mkmkme wants to merge 1 commit intoantalya-26.3from
Open
Antalya 26.3 Backport of #99935 - Support more flexible data paths validation in iceberg#1769mkmkme wants to merge 1 commit intoantalya-26.3from
mkmkme wants to merge 1 commit intoantalya-26.3from
Conversation
…_iceberg Support more flexible data paths validation in iceberg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note for reviewer
While applying this backport, I faced conflicts related to the fact that upstream introduced
IcebergPath.cppin 755a11b. I found the old place of the same code inUtils.cppand fixed it there instead.Also, with just these changes, stateless test
04033was still failing, so I had to apply an additional check ingetProperFilePathFromMetadataInfowhich is aligned with the state ofIcebergPath.cppin the upstream.All the added tests are passing locally for me.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Now ClickHouse should properly handle spark-style tables (where we have full absolute path for each file or relative path to common table path) (ClickHouse#99935 by @alesapin)
Documentation entry for user-facing changes
...
CI/CD Options
Exclude tests:
Regression jobs to run: